Sign upLogin

Smile-SA/elasticsuite

View on GitHub
Star
src/module-elasticsuite-catalog-optimizer/Controller/Adminhtml/Optimizer/Save.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function execute has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute()
    {
        /** @var \Magento\Backend\Model\View\Result\Redirect $resultRedirect */
        $resultRedirect = $this->resultRedirectFactory->create();
        $data = $this->getRequest()->getPostValue();
Severity: Minor
Found in src/module-elasticsuite-catalog-optimizer/Controller/Adminhtml/Optimizer/Save.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return $resultRedirect->setPath('*/*/');
Severity: Major
Found in src/module-elasticsuite-catalog-optimizer/Controller/Adminhtml/Optimizer/Save.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                    return $resultRedirect->setPath('*/*/');
    Severity: Minor
    Found in src/module-elasticsuite-catalog-optimizer/Controller/Adminhtml/Optimizer/Save.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                          return $resultRedirect->setPath('*/*/edit', $redirectParams);
      Severity: Minor
      Found in src/module-elasticsuite-catalog-optimizer/Controller/Adminhtml/Optimizer/Save.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return $resultRedirect->setPath('*/*/edit', $returnParams);
        Severity: Major
        Found in src/module-elasticsuite-catalog-optimizer/Controller/Adminhtml/Optimizer/Save.php - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status