Sign upLogin

Smile-SA/elasticsuite

View on GitHub
Star
src/module-elasticsuite-catalog-rule/Model/Rule.php

Summary

Maintainability
A
1 hr
Test Coverage

Function arrayToConditionDataModel has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    protected function arrayToConditionDataModel(array $input)
    {
        /** @var \Smile\ElasticsuiteCatalogRule\Model\Data\Condition $conditionDataModel */
        $conditionDataModel = $this->conditionDataFactory->create();
        foreach ($input as $key => $value) {
Severity: Minor
Found in src/module-elasticsuite-catalog-rule/Model/Rule.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

        \Magento\Framework\Model\Context $context,
        \Magento\Framework\Registry $registry,
        \Magento\Framework\Data\FormFactory $formFactory,
        \Magento\Framework\Stdlib\DateTime\TimezoneInterface $localeDate,
        \Smile\ElasticsuiteCatalogRule\Model\Rule\Condition\CombineFactory $conditionsFactory,
Severity: Major
Found in src/module-elasticsuite-catalog-rule/Model/Rule.php - About 50 mins to fix

    Returning type null but getSearchQuery() is declared to return \Smile\ElasticsuiteCore\Search\Request\QueryInterface
    Open

            return $query;
    Severity: Minor
    Found in src/module-elasticsuite-catalog-rule/Model/Rule.php by phan

    Argument 1 (condition) is \Magento\Framework\Api\ExtensibleDataInterface|\Smile\ElasticsuiteCatalogRule\Api\Data\ConditionInterface but \Smile\ElasticsuiteCatalogRule\Model\Rule::dataModelToArray() takes \Smile\ElasticsuiteCatalogRule\Model\Data\Condition defined at /code/src/module-elasticsuite-catalog-rule/Model/Rule.php:181
    Open

                    $conditions[] = $this->dataModelToArray($subCondition, $key);
    Severity: Minor
    Found in src/module-elasticsuite-catalog-rule/Model/Rule.php by phan

    There are no issues that match your filters.

    Category
    Status