Sign upLogin

Smile-SA/elasticsuite

View on GitHub
Star
src/module-elasticsuite-catalog-rule/Model/Rule/Condition/Product.php

Summary

Maintainability
B
6 hrs
Test Coverage

Product has 12 functions (exceeds 10 allowed). Consider refactoring.
Open

class Product extends \Magento\Rule\Model\Condition\Product\AbstractProduct
{
    /**
     * @var AttributeList
     */
Severity: Minor
Found in src/module-elasticsuite-catalog-rule/Model/Rule/Condition/Product.php - About 2 hrs to fix

    Method __construct has 13 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            Context $context,
        Data $backendData,
        Config $config,
        AttributeList $attributeList,
        QueryBuilder $queryBuilder,
    Severity: Major
    Found in src/module-elasticsuite-catalog-rule/Model/Rule/Condition/Product.php - About 1 hr to fix

      Function getInputType has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getInputType()
    {
        $inputType        = 'string';
        $selectAttributes = ['attribute_set_id'];
      Severity: Minor
      Found in src/module-elasticsuite-catalog-rule/Model/Rule/Condition/Product.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getValueElementType has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getValueElementType()
    {
        $valueElementType = 'text';

        if ($this->getAttribute() == 'attribute_set_id') {
      Severity: Minor
      Found in src/module-elasticsuite-catalog-rule/Model/Rule/Condition/Product.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _prepareValueOptions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function _prepareValueOptions()
    {
        $selectReady = $this->getData('value_select_options');
        $hashedReady = $this->getData('value_option');
      Severity: Minor
      Found in src/module-elasticsuite-catalog-rule/Model/Rule/Condition/Product.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status