Smile-SA/elasticsuite

View on GitHub
src/module-elasticsuite-catalog/Block/Navigation/Renderer/Slider.php

Summary

Maintainability
B
6 hrs
Test Coverage

Slider has 14 functions (exceeds 10 allowed). Consider refactoring.
Open

class Slider extends AbstractRenderer
{
    /**
     * The Data role, used for Javascript mapping of slider Widget
     *
Severity: Minor
Found in src/module-elasticsuite-catalog/Block/Navigation/Renderer/Slider.php - About 2 hrs to fix

    Method prepareAdaptiveIntervals has 49 lines of code (exceeds 40 allowed). Consider refactoring.
    Open

        private function prepareAdaptiveIntervals(): array
        {
            $adaptiveIntervals = [];
            $intervals = $this->getIntervals();
    
    

      Function showAdaptiveSlider has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public function showAdaptiveSlider(): bool
          {
              $showAdaptiveSlider = false;
              if ($this->catalogSliderHelper->isAdaptiveSliderEnabled()
                  && ($this->getFilter()->getItemsCount() >= CatalogSliderHelper::ADAPTIVE_MINIMUM_ITEMS)

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              Context $context,
              CatalogHelper $catalogHelper,
              EncoderInterface $jsonEncoder,
              FormatInterface $localeFormat,
              CatalogSliderHelper $catalogSliderHelper,
      Severity: Minor
      Found in src/module-elasticsuite-catalog/Block/Navigation/Renderer/Slider.php - About 45 mins to fix

        Function prepareAdaptiveIntervals has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            private function prepareAdaptiveIntervals(): array
            {
                $adaptiveIntervals = [];
                $intervals = $this->getIntervals();
        
        
        Severity: Minor
        Found in src/module-elasticsuite-catalog/Block/Navigation/Renderer/Slider.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status