Sign upLogin

Smile-SA/elasticsuite

View on GitHub
Star
src/module-elasticsuite-catalog/Helper/AbstractAttribute.php

Summary

Maintainability
C
1 day
Test Coverage

AbstractAttribute has 17 functions (exceeds 10 allowed). Consider refactoring.
Open

abstract class AbstractAttribute extends Mapping
{
    /**
     * @var \Magento\Catalog\Model\ResourceModel\Eav\AttributeFactory
     */
Severity: Minor
Found in src/module-elasticsuite-catalog/Helper/AbstractAttribute.php - About 3 hrs to fix

    Function prepareIndexValue has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public function prepareIndexValue($attributeId, $storeId, $value)
    {
        // Backward compatibility.
        if (!is_numeric($attributeId)) {
            $attributeId = $this->getAttributeId($attributeId);
    Severity: Minor
    Found in src/module-elasticsuite-catalog/Helper/AbstractAttribute.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getFieldType has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getFieldType($attributeId)
    {
        // Backward compatibility.
        if (!is_numeric($attributeId)) {
            $attributeId = $this->getAttributeId($attributeId);
    Severity: Minor
    Found in src/module-elasticsuite-catalog/Helper/AbstractAttribute.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getIndexOptionText has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getIndexOptionText($attributeId, $storeId, $optionId)
    {
        $attribute = $this->getAttributeByStore($attributeId, $storeId);

        if (!isset($this->attributeOptionTextCache[$storeId]) || !isset($this->attributeOptionTextCache[$storeId][$attributeId])) {
    Severity: Minor
    Found in src/module-elasticsuite-catalog/Helper/AbstractAttribute.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getMappingFieldOptions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getMappingFieldOptions(AttributeInterface $attribute)
    {
        $options = [
            'is_searchable'       => $attribute->getIsSearchable(),
            'is_filterable'       => $attribute->getIsFilterable() || $attribute->getIsFilterableInSearch(),
    Severity: Minor
    Found in src/module-elasticsuite-catalog/Helper/AbstractAttribute.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return array_filter($values);
    Severity: Minor
    Found in src/module-elasticsuite-catalog/Helper/AbstractAttribute.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                          return !empty($value);
      Severity: Minor
      Found in src/module-elasticsuite-catalog/Helper/AbstractAttribute.php - About 30 mins to fix

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            private function getFrontendClass($attributeId)
    {
        if (!isset($this->attributeFrontendCache[$attributeId])) {
            $attribute = $this->getAttributeById($attributeId);
            $this->attributeFrontendCache[$attributeId] = $attribute->getFrontendClass();
        Severity: Major
        Found in src/module-elasticsuite-catalog/Helper/AbstractAttribute.php and 3 other locations - About 30 mins to fix
        src/module-elasticsuite-catalog/Helper/AbstractAttribute.php on lines 431..442
        src/module-elasticsuite-catalog/Helper/AbstractAttribute.php on lines 470..478
        src/module-elasticsuite-catalog/Helper/AbstractAttribute.php on lines 488..496

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 61.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            private function getBackendType($attributeId)
    {
        if (!isset($this->attributeBackendCache[$attributeId])) {
            $attribute = $this->getAttributeById($attributeId);
            $this->attributeBackendCache[$attributeId] = $attribute->getBackendType();
        Severity: Major
        Found in src/module-elasticsuite-catalog/Helper/AbstractAttribute.php and 3 other locations - About 30 mins to fix
        src/module-elasticsuite-catalog/Helper/AbstractAttribute.php on lines 431..442
        src/module-elasticsuite-catalog/Helper/AbstractAttribute.php on lines 470..478
        src/module-elasticsuite-catalog/Helper/AbstractAttribute.php on lines 505..513

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 61.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            private function usesSource($attributeId)
    {
        if (!isset($this->attributeUsesSourceCache[$attributeId])) {
            $attribute = $this->getAttributeById($attributeId);
            $this->attributeUsesSourceCache[$attributeId] = $attribute->usesSource();
        Severity: Major
        Found in src/module-elasticsuite-catalog/Helper/AbstractAttribute.php and 3 other locations - About 30 mins to fix
        src/module-elasticsuite-catalog/Helper/AbstractAttribute.php on lines 431..442
        src/module-elasticsuite-catalog/Helper/AbstractAttribute.php on lines 488..496
        src/module-elasticsuite-catalog/Helper/AbstractAttribute.php on lines 505..513

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 61.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            private function getAttributeCodeById($attributeId)
    {
        if (!isset($this->attributesCode[$attributeId])) {
            /**
             * @var EavAttributeInterface
        Severity: Major
        Found in src/module-elasticsuite-catalog/Helper/AbstractAttribute.php and 3 other locations - About 30 mins to fix
        src/module-elasticsuite-catalog/Helper/AbstractAttribute.php on lines 470..478
        src/module-elasticsuite-catalog/Helper/AbstractAttribute.php on lines 488..496
        src/module-elasticsuite-catalog/Helper/AbstractAttribute.php on lines 505..513

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 61.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status