Smile-SA/elasticsuite

Collection has 15 functions (exceeds 10 allowed). Consider refactoring.

Open

class Collection extends \Magento\Catalog\Model\ResourceModel\Category\Collection
{
    /**
     * @var \Smile\ElasticsuiteCore\Search\Request\Builder
     */

Method __construct has 14 arguments (exceeds 4 allowed). Consider refactoring.

Open

        \Magento\Framework\Data\Collection\EntityFactory $entityFactory,
        \Psr\Log\LoggerInterface $logger,
        \Magento\Framework\Data\Collection\Db\FetchStrategyInterface $fetchStrategy,
        \Magento\Framework\Event\ManagerInterface $eventManager,
        \Magento\Eav\Model\Config $eavConfig,

Returning type \Smile\ElasticsuiteCatalog\Model\ResourceModel\Category\Fulltext\Collection but setSearchQuery() is declared to return \Smile\ElasticsuiteCatalog\Model\ResourceModel\Product\Fulltext\Collection

Open

        return $this;

• Exclude checks
  • Disable engine
  • Disable check

Saw a token Phan may have failed to parse after '* @return array()': after array, saw '('

Open

     * @return array()

• Exclude checks
  • Disable engine
  • Disable check

TODO found

Open

 * @TODO Refactor/Mutualize all copy/pasted methods.

• Exclude checks
  • Disable engine
  • Disable check

Doc-block of $connection in __construct is phpdoc param type \Magento\Framework\DB\Adapter\AdapterInterface which is not a permitted replacement of the nullable param type ?\Magento\Framework\DB\Adapter\AdapterInterface declared in the signature ('?T' should be documented as 'T|null' or '?T')

Open

     * @param \Magento\Framework\DB\Adapter\AdapterInterface               $connection        Db Connection.

• Exclude checks
  • Disable engine
  • Disable check

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        foreach ($this->queryResponse->getIterator() as $document) {
            $documentId = $document->getId();
            if (isset($originalItems[$documentId])) {
                $originalItems[$documentId]->setDocumentScore($document->getScore());
                $originalItems[$documentId]->setDocumentSource($document->getSource());

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    public function __construct(
        \Magento\Framework\Data\Collection\EntityFactory $entityFactory,
        \Psr\Log\LoggerInterface $logger,
        \Magento\Framework\Data\Collection\Db\FetchStrategyInterface $fetchStrategy,
        \Magento\Framework\Event\ManagerInterface $eventManager,

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        $docIds = array_map(
            function (\Magento\Framework\Api\Search\Document $doc) {
                return (int) $doc->getId();
            },
            $this->queryResponse->getIterator()->getArrayCopy()

• Read up
  Read up