Sign upLogin

Smile-SA/elasticsuite

View on GitHub
Star
src/module-elasticsuite-catalog/Plugin/Catalog/Eav/AttributePlugin.php

Summary

Maintainability
C
7 hrs
Test Coverage

Function checkUpdateNeeded has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

    private function checkUpdateNeeded($subject)
    {
        $updateMapping = $cleanCache = $invalidateIndex = false;

        if ($this->saveIsNew === true) {
Severity: Minor
Found in src/module-elasticsuite-catalog/Plugin/Catalog/Eav/AttributePlugin.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method checkUpdateNeeded has 43 lines of code (exceeds 40 allowed). Consider refactoring.
Open

    private function checkUpdateNeeded($subject)
    {
        $updateMapping = $cleanCache = $invalidateIndex = false;

        if ($this->saveIsNew === true) {
Severity: Minor
Found in src/module-elasticsuite-catalog/Plugin/Catalog/Eav/AttributePlugin.php - About 1 hr to fix

    Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            \Smile\ElasticsuiteCore\Index\Indices\Config $indicesConfig,
        IndexerRegistry $indexerRegistry,
        StoreManagerInterface $storeManager,
        IndexOperationInterface $indexOperation,
        AttributeHelper $attributeHelper,
    Severity: Major
    Found in src/module-elasticsuite-catalog/Plugin/Catalog/Eav/AttributePlugin.php - About 50 mins to fix

      Argument 1 (attribute) is \Magento\Catalog\Api\Data\ProductAttributeInterface but \Smile\ElasticsuiteCatalog\Helper\ProductAttribute::getMappingFieldOptions() takes \Magento\Eav\Model\Entity\Attribute\AttributeInterface defined at /code/src/module-elasticsuite-catalog/Helper/AbstractAttribute.php:123
      Open

              return $this->attributeHelper->getMappingFieldOptions($attribute);
      Severity: Minor
      Found in src/module-elasticsuite-catalog/Plugin/Catalog/Eav/AttributePlugin.php by phan

      Argument 1 (attribute) is \Magento\Catalog\Api\Data\ProductAttributeInterface but \Smile\ElasticsuiteCatalog\Helper\ProductAttribute::getFilterField() takes \Magento\Eav\Model\Entity\Attribute\AttributeInterface defined at /code/src/module-elasticsuite-catalog/Helper/AbstractAttribute.php:338
      Open

                  $fields = array_unique([$subject->getAttributeCode(), $this->attributeHelper->getFilterField($subject)]);
      Severity: Minor
      Found in src/module-elasticsuite-catalog/Plugin/Catalog/Eav/AttributePlugin.php by phan

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

          public function __construct(
        \Smile\ElasticsuiteCore\Index\Indices\Config $indicesConfig,
        IndexerRegistry $indexerRegistry,
        StoreManagerInterface $storeManager,
        IndexOperationInterface $indexOperation,
      Severity: Major
      Found in src/module-elasticsuite-catalog/Plugin/Catalog/Eav/AttributePlugin.php and 7 other locations - About 40 mins to fix
      src/module-elasticsuite-analytics/Model/Search/Usage/Terms/ConversionRatePostProcessor.php on lines 76..92
      src/module-elasticsuite-catalog-graph-ql/DataProvider/Product/LayeredNavigation/Builder/Category.php on lines 95..111
      src/module-elasticsuite-catalog/Model/ProductSorter/AbstractPreview.php on lines 78..94
      src/module-elasticsuite-catalog/Plugin/CatalogSearch/ResultPlugin.php on lines 88..104
      src/module-elasticsuite-core/Indexer/GenericIndexerHandler.php on lines 81..97
      src/module-elasticsuite-core/Search/Request/Query/Boolean.php on lines 76..92
      src/module-elasticsuite-tracker/Model/IndexManager.php on lines 79..95

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status