Sign upLogin

Smile-SA/elasticsuite

View on GitHub
Star
src/module-elasticsuite-catalog/Search/Request/Product/Aggregation/Provider/FilterableAttributes/Modifier/Statistics.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function modifyAggregations has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    public function modifyAggregations($storeId, $requestName, $aggregations, $query, $filters, $queryFilters)
    {
        if ($this->sliderHelper->isAdaptiveSliderEnabled()) {
            foreach ($this->applicableAttributes as $attribute) {
                $field = $this->requestFieldMapper->getMappedFieldName($attribute->getAttributeCode());
Severity: Minor
Found in src/module-elasticsuite-catalog/Search/Request/Product/Aggregation/Provider/FilterableAttributes/Modifier/Statistics.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method modifyAggregations has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function modifyAggregations($storeId, $requestName, $aggregations, $query, $filters, $queryFilters)
Severity: Minor
Found in src/module-elasticsuite-catalog/Search/Request/Product/Aggregation/Provider/FilterableAttributes/Modifier/Statistics.php - About 45 mins to fix

    Method modifyAttributes has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function modifyAttributes($storeId, $requestName, $attributes, $query, $filters, $queryFilters)
    Severity: Minor
    Found in src/module-elasticsuite-catalog/Search/Request/Product/Aggregation/Provider/FilterableAttributes/Modifier/Statistics.php - About 45 mins to fix

      Function modifyAttributes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function modifyAttributes($storeId, $requestName, $attributes, $query, $filters, $queryFilters)
    {
        $this->applicableAttributes = [];

        if ($this->sliderHelper->isAdaptiveSliderEnabled()) {
      Severity: Minor
      Found in src/module-elasticsuite-catalog/Search/Request/Product/Aggregation/Provider/FilterableAttributes/Modifier/Statistics.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Argument 1 (attribute) is \Magento\Catalog\Model\ResourceModel\Product\Attribute but \Smile\ElasticsuiteCatalog\Search\Request\Product\Aggregation\Provider\FilterableAttributes\Modifier\Statistics\AttributeFilterInterface::filterAttribute() takes \Magento\Catalog\Model\ResourceModel\Eav\Attribute defined at /code/src/module-elasticsuite-catalog/Search/Request/Product/Aggregation/Provider/FilterableAttributes/Modifier/Statistics/AttributeFilterInterface.php:34
      Open

                      if ($this->attributeFilter->filterAttribute($attribute)) {
      Severity: Minor
      Found in src/module-elasticsuite-catalog/Search/Request/Product/Aggregation/Provider/FilterableAttributes/Modifier/Statistics.php by phan

      Assigning array<int></int> to property but \Smile\ElasticsuiteCatalog\Search\Request\Product\Aggregation\Provider\FilterableAttributes\Modifier\Statistics->applicableAttributes is \Magento\Catalog\Model\ResourceModel\Eav\Attribute[]
      Open

                          $this->applicableAttributes[] = $attribute;
      Severity: Minor
      Found in src/module-elasticsuite-catalog/Search/Request/Product/Aggregation/Provider/FilterableAttributes/Modifier/Statistics.php by phan

      There are no issues that match your filters.

      Category
      Status