Sign upLogin

Smile-SA/elasticsuite

View on GitHub
Star
src/module-elasticsuite-core/Model/DataProvider/Suggestions.php

Summary

Maintainability
B
6 hrs
Test Coverage

Method getSuggestions has 43 lines of code (exceeds 40 allowed). Consider refactoring.
Open

    private function getSuggestions(string $queryText, int $maxSize = self::MAX_COUNT)
    {
        $suggestions     = [];
        $containerConfig = $this->getRequestContainerConfiguration(
            $this->storeManager->getStore()->getId(),
Severity: Minor
Found in src/module-elasticsuite-core/Model/DataProvider/Suggestions.php - About 1 hr to fix

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            QueryResultFactory $queryResultFactory,
        StoreManagerInterface $storeManager,
        ClientInterface $client,
        ContainerConfigurationFactory $containerConfigFactory,
        ScopeConfigInterface $scopeConfig
    Severity: Minor
    Found in src/module-elasticsuite-core/Model/DataProvider/Suggestions.php - About 35 mins to fix

      Function getSuggestions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private function getSuggestions(string $queryText, int $maxSize = self::MAX_COUNT)
    {
        $suggestions     = [];
        $containerConfig = $this->getRequestContainerConfiguration(
            $this->storeManager->getStore()->getId(),
      Severity: Minor
      Found in src/module-elasticsuite-core/Model/DataProvider/Suggestions.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      syntax error, unexpected 'QueryResultFactory' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
      Open

          private QueryResultFactory $queryResultFactory;
      Severity: Critical
      Found in src/module-elasticsuite-core/Model/DataProvider/Suggestions.php by phan

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          private function getRequestContainerConfiguration($storeId, $containerName)
    {
        if ($containerName === null) {
            throw new \LogicException('Request name is not set');
        }
      Severity: Major
      Found in src/module-elasticsuite-core/Model/DataProvider/Suggestions.php and 1 other location - About 2 hrs to fix
      src/module-elasticsuite-core/Search/Request/Builder.php on lines 264..279

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 88.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

          public function __construct(
        QueryResultFactory $queryResultFactory,
        StoreManagerInterface $storeManager,
        ClientInterface $client,
        ContainerConfigurationFactory $containerConfigFactory,
      Severity: Major
      Found in src/module-elasticsuite-core/Model/DataProvider/Suggestions.php and 5 other locations - About 1 hr to fix
      src/module-elasticsuite-catalog/Plugin/Ui/Category/Form/DataProviderPlugin.php on lines 77..89
      src/module-elasticsuite-core/Model/Search/Request/RelevanceConfig/Reader/ContainerStore.php on lines 66..78
      src/module-elasticsuite-core/Search/Request/SortOrder/SortOrderBuilder.php on lines 69..81
      src/module-elasticsuite-tracker/Observer/TrackRedirectIfOneResult.php on lines 65..77
      src/module-elasticsuite-virtual-category/Controller/Router.php on lines 73..85

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 84.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status