Sign upLogin

Smile-SA/elasticsuite

View on GitHub
Star
src/module-elasticsuite-core/Model/ProductMetadata.php

Summary

Maintainability
A
35 mins
Test Coverage

Function getVersion has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function getVersion()
    {
        $this->version = $this->version ?: $this->cache->load(self::VERSION_CACHE_KEY);

        if (!$this->version) {
Severity: Minor
Found in src/module-elasticsuite-core/Model/ProductMetadata.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Doc-block of $cache in __construct is phpdoc param type \Magento\Framework\App\CacheInterface which is not a permitted replacement of the nullable param type ?\Magento\Framework\App\CacheInterface declared in the signature ('?T' should be documented as 'T|null' or '?T')
Open

     * @param \Magento\Framework\App\CacheInterface $cache              Cache interface
Severity: Minor
Found in src/module-elasticsuite-core/Model/ProductMetadata.php by phan

There are no issues that match your filters.

Category
Status