Smile-SA/elasticsuite

View on GitHub
src/module-elasticsuite-core/Search/Request/ContainerConfiguration/RelevanceConfig/Factory.php

Summary

Maintainability
C
1 day
Test Coverage

Factory has 24 functions (exceeds 10 allowed). Consider refactoring.
Open

class Factory
{
    /**
     * XML root node for search relevance
     */

    Saw unextractable annotation for comment '* @param @param string $scopeCode The scope code'
    Open

         * @param @param string $scopeCode The scope code

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        private function getSpanMatchBoostConfiguration($scopeCode)
        {
            $path = self::BASE_RELEVANCE_CONFIG_XML_PREFIX . "/" . self::SPAN_MATCH_CONFIG_XML_PREFIX;
    
            $boost = (bool) $this->getConfigValue($path . "/enable_span_match", $scopeCode);
    src/module-elasticsuite-core/Search/Request/ContainerConfiguration/RelevanceConfig/Factory.php on lines 259..270
    src/module-elasticsuite-core/Search/Request/ContainerConfiguration/RelevanceConfig/Factory.php on lines 354..365
    src/module-elasticsuite-core/Search/Request/ContainerConfiguration/RelevanceConfig/Factory.php on lines 374..385

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 88.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        private function getPhraseMatchBoostConfiguration($scopeCode)
        {
            $path = self::BASE_RELEVANCE_CONFIG_XML_PREFIX . "/" . self::PHRASE_MATCH_CONFIG_XML_PREFIX;
    
            $boost = (bool) $this->getConfigValue($path . "/enable_phrase_match", $scopeCode);
    src/module-elasticsuite-core/Search/Request/ContainerConfiguration/RelevanceConfig/Factory.php on lines 334..345
    src/module-elasticsuite-core/Search/Request/ContainerConfiguration/RelevanceConfig/Factory.php on lines 354..365
    src/module-elasticsuite-core/Search/Request/ContainerConfiguration/RelevanceConfig/Factory.php on lines 374..385

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 88.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        private function getMinScoreConfiguration($scopeCode)
        {
            $path = self::BASE_RELEVANCE_CONFIG_XML_PREFIX . "/" . self::MIN_SCORE_CONFIG_XML_PREFIX;
    
            $minScore = (bool) $this->getConfigValue($path . "/enable_use_min_score", $scopeCode);
    src/module-elasticsuite-core/Search/Request/ContainerConfiguration/RelevanceConfig/Factory.php on lines 259..270
    src/module-elasticsuite-core/Search/Request/ContainerConfiguration/RelevanceConfig/Factory.php on lines 334..345
    src/module-elasticsuite-core/Search/Request/ContainerConfiguration/RelevanceConfig/Factory.php on lines 354..365

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 88.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        private function getSpanSize($scopeCode)
        {
            $path = self::BASE_RELEVANCE_CONFIG_XML_PREFIX . "/" . self::SPAN_MATCH_CONFIG_XML_PREFIX;
    
            $size = (bool) $this->getConfigValue($path . "/enable_span_match", $scopeCode);
    src/module-elasticsuite-core/Search/Request/ContainerConfiguration/RelevanceConfig/Factory.php on lines 259..270
    src/module-elasticsuite-core/Search/Request/ContainerConfiguration/RelevanceConfig/Factory.php on lines 334..345
    src/module-elasticsuite-core/Search/Request/ContainerConfiguration/RelevanceConfig/Factory.php on lines 374..385

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 88.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status