Sign upLogin

Smile-SA/elasticsuite

View on GitHub
Star
src/module-elasticsuite-core/Search/Request/Query/MultiMatch.php

Summary

Maintainability
B
5 hrs
Test Coverage

MultiMatch has 12 functions (exceeds 10 allowed). Consider refactoring.
Open

class MultiMatch implements QueryInterface
{
    /**
     * @var string
     */
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request/Query/MultiMatch.php - About 2 hrs to fix

    Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $queryText,
        array $fields,
        $minimumShouldMatch = self::DEFAULT_MINIMUM_SHOULD_MATCH,
        $tieBreaker = self::DEFAULT_TIE_BREAKER,
        $name = null,
    Severity: Major
    Found in src/module-elasticsuite-core/Search/Request/Query/MultiMatch.php - About 1 hr to fix

      Declaration of function setName($name) : \Smile\ElasticsuiteCore\Search\Request\Query\MultiMatch should be compatible with function setName(string $name) : \Smile\ElasticsuiteCore\Search\Request\QueryInterface (parameter #1 with no type cannot replace original parameter with type 'string') defined in /code/src/module-elasticsuite-core/Search/Request/QueryInterface.php:49
      Open

          public function setName($name): self
      Severity: Minor
      Found in src/module-elasticsuite-core/Search/Request/Query/MultiMatch.php by phan

      Declaration of function setName($name) : \Smile\ElasticsuiteCore\Search\Request\Query\MultiMatch should be compatible with function setName(string $name) : \Smile\ElasticsuiteCore\Search\Request\QueryInterface (method returning '\Smile\ElasticsuiteCore\Search\Request\Query\MultiMatch' cannot override method returning '\Smile\ElasticsuiteCore\Search\Request\QueryInterface') defined in /code/src/module-elasticsuite-core/Search/Request/QueryInterface.php:49
      Open

          public function setName($name): self
      Severity: Critical
      Found in src/module-elasticsuite-core/Search/Request/Query/MultiMatch.php by phan

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function __construct(
        $queryText,
        array $fields,
        $minimumShouldMatch = self::DEFAULT_MINIMUM_SHOULD_MATCH,
        $tieBreaker = self::DEFAULT_TIE_BREAKER,
      Severity: Major
      Found in src/module-elasticsuite-core/Search/Request/Query/MultiMatch.php and 1 other location - About 1 hr to fix
      src/module-elasticsuite-core/Search/Request/Builder.php on lines 97..117

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 82.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status