Smile-SA/elasticsuite

View on GitHub
src/module-elasticsuite-core/Search/Request/Query/Nested.php

Summary

Maintainability
A
35 mins
Test Coverage

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $path,
        \Magento\Framework\Search\Request\QueryInterface $query = null,
        $scoreMode = self::SCORE_MODE_NONE,
        $name = null,
        $boost = QueryInterface::DEFAULT_BOOST_VALUE
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request/Query/Nested.php - About 35 mins to fix

    Declaration of function setName($name) : \Smile\ElasticsuiteCore\Search\Request\Query\Nested should be compatible with function setName(string $name) : \Smile\ElasticsuiteCore\Search\Request\QueryInterface (parameter #1 with no type cannot replace original parameter with type 'string') defined in /code/src/module-elasticsuite-core/Search/Request/QueryInterface.php:50
    Open

        public function setName($name): self

    Doc-block of $query in __construct is phpdoc param type \Magento\Framework\Search\Request\QueryInterface which is not a permitted replacement of the nullable param type ?\Magento\Framework\Search\Request\QueryInterface declared in the signature ('?T' should be documented as 'T|null' or '?T')
    Open

         * @param \Magento\Framework\Search\Request\QueryInterface $query     Nested query.

    Declaration of function setName($name) : \Smile\ElasticsuiteCore\Search\Request\Query\Nested should be compatible with function setName(string $name) : \Smile\ElasticsuiteCore\Search\Request\QueryInterface (method returning '\Smile\ElasticsuiteCore\Search\Request\Query\Nested' cannot override method returning '\Smile\ElasticsuiteCore\Search\Request\QueryInterface') defined in /code/src/module-elasticsuite-core/Search/Request/QueryInterface.php:50
    Open

        public function setName($name): self

    Assigning ?\Magento\Framework\Search\Request\QueryInterface to property but \Smile\ElasticsuiteCore\Search\Request\Query\Nested->query is \Smile\ElasticsuiteCore\Search\Request\QueryInterface
    Open

            $this->query     = $query;

    There are no issues that match your filters.

    Category
    Status