Sign upLogin

Smile-SA/elasticsuite

View on GitHub
Star
src/module-elasticsuite-core/Search/Request/Query/Span/SpanContaining.php

Summary

Maintainability
B
6 hrs
Test Coverage

Doc-block of $name in __construct is phpdoc param type string which is not a permitted replacement of the nullable param type ?string declared in the signature ('?T' should be documented as 'T|null' or '?T')
Open

     * @param string                                                          $name   Query Name
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request/Query/Span/SpanContaining.php by phan

Declaration of function setName($name) : \Smile\ElasticsuiteCore\Search\Request\Query\Span\SpanContaining should be compatible with function setName(string $name) : \Smile\ElasticsuiteCore\Search\Request\QueryInterface (parameter #1 with no type cannot replace original parameter with type 'string') defined in /code/src/module-elasticsuite-core/Search/Request/QueryInterface.php:50
Open

    public function setName($name): self
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request/Query/Span/SpanContaining.php by phan

Declaration of function setName($name) : \Smile\ElasticsuiteCore\Search\Request\Query\Span\SpanContaining should be compatible with function setName(string $name) : \Smile\ElasticsuiteCore\Search\Request\QueryInterface (method returning '\Smile\ElasticsuiteCore\Search\Request\Query\Span\SpanContaining' cannot override method returning '\Smile\ElasticsuiteCore\Search\Request\QueryInterface') defined in /code/src/module-elasticsuite-core/Search/Request/QueryInterface.php:50
Open

    public function setName($name): self
Severity: Critical
Found in src/module-elasticsuite-core/Search/Request/Query/Span/SpanContaining.php by phan

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php
/**
 * DISCLAIMER
 *
 * Do not edit or add to this file if you wish to upgrade Smile ElasticSuite to newer
Severity: Major
Found in src/module-elasticsuite-core/Search/Request/Query/Span/SpanContaining.php and 2 other locations - About 6 hrs to fix
src/module-elasticsuite-core/Search/Request/Query/Span/SpanNot.php on lines 1..119
src/module-elasticsuite-core/Search/Request/Query/Span/SpanWithin.php on lines 1..119

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 175.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status