Smile-SA/elasticsuite

View on GitHub
src/module-elasticsuite-indices/Controller/Adminhtml/Index/Delete.php

Summary

Maintainability
A
1 hr
Test Coverage

Avoid too many return statements within this method.
Open

            return $resultRedirect->setPath('*/*/index');
Severity: Minor
Found in src/module-elasticsuite-indices/Controller/Adminhtml/Index/Delete.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return $resultRedirect->setPath('*/*/index');
    Severity: Minor
    Found in src/module-elasticsuite-indices/Controller/Adminhtml/Index/Delete.php - About 30 mins to fix

      Function execute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function execute()
          {
              /** @var Redirect $resultRedirect */
              $resultRedirect = $this->resultRedirectFactory->create();
      
      
      Severity: Minor
      Found in src/module-elasticsuite-indices/Controller/Adminhtml/Index/Delete.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Possibly zero references to use statement for classlike/namespace Redirect (\Magento\Backend\Model\View\Result\Redirect)
      Open

      use Magento\Backend\Model\View\Result\Redirect;

      There are no issues that match your filters.

      Category
      Status