Sign upLogin

Smile-SA/elasticsuite

View on GitHub
Star
src/module-elasticsuite-indices/Model/IndexStatsProvider.php

Summary

Maintainability
A
25 mins
Test Coverage

Function getElasticSuiteIndices has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function getElasticSuiteIndices($params = []): array
    {
        if ($this->elasticsuiteIndices === null) {
            $this->elasticsuiteIndices = [];
Severity: Minor
Found in src/module-elasticsuite-indices/Model/IndexStatsProvider.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Suspicious array access to null
Open

                    $this->elasticsuiteIndices[$name] = $aliases ? key($aliases['aliases']) : null;
Severity: Minor
Found in src/module-elasticsuite-indices/Model/IndexStatsProvider.php by phan

Suspicious array access to null
Open

                $this->indicesStats[$indexName] = current($indexStatsResponse['indices']);
Severity: Minor
Found in src/module-elasticsuite-indices/Model/IndexStatsProvider.php by phan

Assigning array<string>|array<string></string></string> to property but \Smile\ElasticsuiteIndices\Model\IndexStatsProvider->indicesStats is null
Open

                $this->indicesStats[$indexName] = current($indexStatsResponse['indices']);
Severity: Minor
Found in src/module-elasticsuite-indices/Model/IndexStatsProvider.php by phan

Assigning array{} to property but \Smile\ElasticsuiteIndices\Model\IndexStatsProvider->indicesStats is null
Open

                $this->indicesStats = [];
Severity: Minor
Found in src/module-elasticsuite-indices/Model/IndexStatsProvider.php by phan

Assigning false[]|int[]|null[]|string[] to property but \Smile\ElasticsuiteIndices\Model\IndexStatsProvider->elasticsuiteIndices is null
Open

                    $this->elasticsuiteIndices[$name] = $aliases ? key($aliases['aliases']) : null;
Severity: Minor
Found in src/module-elasticsuite-indices/Model/IndexStatsProvider.php by phan

Argument 1 (array_arg) is null but \ksort() takes array
Open

            ksort($this->elasticsuiteIndices, SORT_STRING | SORT_NATURAL);
Severity: Minor
Found in src/module-elasticsuite-indices/Model/IndexStatsProvider.php by phan

Assigning array{} to property but \Smile\ElasticsuiteIndices\Model\IndexStatsProvider->elasticsuiteIndices is null
Open

            $this->elasticsuiteIndices = [];
Severity: Minor
Found in src/module-elasticsuite-indices/Model/IndexStatsProvider.php by phan

There are no issues that match your filters.

Category
Status