Sign upLogin

Smile-SA/elasticsuite

View on GitHub
Star
src/module-elasticsuite-thesaurus/Model/Index.php

Summary

Maintainability
B
6 hrs
Test Coverage

Index has 12 functions (exceeds 10 allowed). Consider refactoring.
Open

class Index
{
    /**
     * @var string
     */
Severity: Minor
Found in src/module-elasticsuite-thesaurus/Model/Index.php - About 2 hrs to fix

    Function getSynonymRewrites has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        private function getSynonymRewrites($storeId, $queryText, $type, $maxRewrites)
    {
        $indexName        = $this->getIndexAlias($storeId);
        $analyzedQueries  = $this->getQueryCombinations($storeId, str_replace('-', ' ', $queryText));
        $synonyms         = [];
    Severity: Minor
    Found in src/module-elasticsuite-thesaurus/Model/Index.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function combineSynonyms has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        private function combineSynonyms($queryText, $synonymByPositions, $maxRewrites, $substitutions = 0, $offset = 0)
    {
        $combinations = [];

        if (!empty($synonymByPositions) && $substitutions < $maxRewrites) {
    Severity: Minor
    Found in src/module-elasticsuite-thesaurus/Model/Index.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method combineSynonyms has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        private function combineSynonyms($queryText, $synonymByPositions, $maxRewrites, $substitutions = 0, $offset = 0)
    Severity: Minor
    Found in src/module-elasticsuite-thesaurus/Model/Index.php - About 35 mins to fix

      Returning type \Smile\ElasticsuiteCore\Api\Search\Request\Container\RelevanceConfigurationInterface but getConfig() is declared to return \Smile\ElasticsuiteThesaurus\Config\ThesaurusConfig
      Open

              return $this->thesaurusConfigFactory->create($storeId, $containerName);
      Severity: Minor
      Found in src/module-elasticsuite-thesaurus/Model/Index.php by phan

      Argument 3 (baseWeight) is float but \Smile\ElasticsuiteThesaurus\Model\Index::getWeightedRewrites() takes int defined at /code/src/module-elasticsuite-thesaurus/Model/Index.php:351
      Open

                  $rewrites        = $this->getWeightedRewrites($synonymRewrites, $config->getSynonymWeightDivider(), $originalBoost);
      Severity: Minor
      Found in src/module-elasticsuite-thesaurus/Model/Index.php by phan

      Similar blocks of code found in 17 locations. Consider refactoring.
      Open

          public function __construct(
        ClientInterface $client,
        IndexSettingsHelper $indexSettingsHelper,
        CacheHelper $cacheHelper,
        ThesaurusConfigFactory $thesaurusConfigFactory
      Severity: Major
      Found in src/module-elasticsuite-thesaurus/Model/Index.php and 16 other locations - About 55 mins to fix
      src/module-elasticsuite-catalog-graph-ql/Model/Resolver/Aggregations.php on lines 62..72
      src/module-elasticsuite-catalog-graph-ql/Model/Resolver/Products/ContextUpdater.php on lines 57..67
      src/module-elasticsuite-catalog-optimizer/Model/Optimizer/Preview/SearchQuery.php on lines 60..70
      src/module-elasticsuite-catalog/Model/Category/Indexer/Fulltext.php on lines 61..71
      src/module-elasticsuite-catalog/Plugin/Category/Toolbar/SortDirectionPerCategoryPlugin.php on lines 67..77
      src/module-elasticsuite-core/Model/Search.php on lines 59..69
      src/module-elasticsuite-core/Model/Search/Request/RelevanceConfig/Reader/Container.php on lines 58..68
      src/module-elasticsuite-core/Search/Adapter/Elasticsuite/Adapter.php on lines 60..70
      src/module-elasticsuite-core/Search/Adapter/Elasticsuite/Request/Mapper.php on lines 60..70
      src/module-elasticsuite-core/Search/Request/Aggregation/AggregationBuilder.php on lines 60..70
      src/module-elasticsuite-thesaurus/Model/Indexer/IndexHandler.php on lines 60..70
      src/module-elasticsuite-thesaurus/Model/ThesaurusRepository.php on lines 77..87
      src/module-elasticsuite-tracker/Model/Data/Fixer/Event/DeleteUndefinedSessionId.php on lines 64..74
      src/module-elasticsuite-tracker/Model/Data/Fixer/Session/DeleteUndefinedSessionId.php on lines 64..74
      src/module-elasticsuite-tracker/Model/System/Message/WarningAboutInvalidTrackerEvents.php on lines 57..67
      src/module-elasticsuite-virtual-category/Model/VirtualCategory/Root.php on lines 58..68

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 68.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status