Sign upLogin

Smile-SA/elasticsuite

View on GitHub
Star
src/module-elasticsuite-thesaurus/Model/ResourceModel/Thesaurus/Collection.php

Summary

Maintainability
D
2 days
Test Coverage

Function loadStores has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    private function loadStores()
    {
        $itemIds = array_keys($this->_items);

        if (count($itemIds)) {
Severity: Minor
Found in src/module-elasticsuite-thesaurus/Model/ResourceModel/Thesaurus/Collection.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Collection has 13 functions (exceeds 10 allowed). Consider refactoring.
Open

class Collection extends \Magento\Framework\Model\ResourceModel\Db\Collection\AbstractCollection
{
    /**
     * Store for filter
     *
Severity: Minor
Found in src/module-elasticsuite-thesaurus/Model/ResourceModel/Thesaurus/Collection.php - About 2 hrs to fix

    Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            \Magento\Framework\Data\Collection\EntityFactoryInterface $entityFactory,
        \Psr\Log\LoggerInterface $logger,
        \Magento\Framework\Data\Collection\Db\FetchStrategyInterface $fetchStrategy,
        \Magento\Framework\Event\ManagerInterface $eventManager,
        \Magento\Store\Model\StoreManagerInterface $storeManager,
    Severity: Major
    Found in src/module-elasticsuite-thesaurus/Model/ResourceModel/Thesaurus/Collection.php - About 1 hr to fix

      Doc-block of $resource in __construct is phpdoc param type \Magento\Framework\Model\ResourceModel\Db\AbstractDb which is not a permitted replacement of the nullable param type ?\Magento\Framework\Model\ResourceModel\Db\AbstractDb declared in the signature ('?T' should be documented as 'T|null' or '?T')
      Open

           * @param \Magento\Framework\Model\ResourceModel\Db\AbstractDb         $resource       Abstract Resource
      Severity: Minor
      Found in src/module-elasticsuite-thesaurus/Model/ResourceModel/Thesaurus/Collection.php by phan

      Doc-block of $entityFactory in __construct contains phpdoc param type \Magento\Framework\Data\Collection\EntityFactory which is incompatible with the param type \Magento\Framework\Data\Collection\EntityFactoryInterface declared in the signature
      Open

           * @param \Magento\Framework\Data\Collection\EntityFactory             $entityFactory  Entity Factory
      Severity: Minor
      Found in src/module-elasticsuite-thesaurus/Model/ResourceModel/Thesaurus/Collection.php by phan

      Class \Smile\ElasticsuiteThesaurus\Model\ResourceModel\Thesaurus\Collection was passed to foreach, but it does not extend Traversable. This may be intentional, because some of that class's declared properties are accessible from this context. (This check excludes dynamic properties)
      Open

                      foreach ($this as $item) {
      Severity: Minor
      Found in src/module-elasticsuite-thesaurus/Model/ResourceModel/Thesaurus/Collection.php by phan

      Suspicious array access to ?mixed
      Open

                  $labelsByThesaurusId[$currentTerm['thesaurus_id']][] = $label;
      Severity: Minor
      Found in src/module-elasticsuite-thesaurus/Model/ResourceModel/Thesaurus/Collection.php by phan

      Doc-block of $connection in __construct is phpdoc param type \Magento\Framework\DB\Adapter\AdapterInterface which is not a permitted replacement of the nullable param type ?\Magento\Framework\DB\Adapter\AdapterInterface declared in the signature ('?T' should be documented as 'T|null' or '?T')
      Open

           * @param \Magento\Framework\DB\Adapter\AdapterInterface               $connection     Database Connection
      Severity: Minor
      Found in src/module-elasticsuite-thesaurus/Model/ResourceModel/Thesaurus/Collection.php by phan

      Suspicious array access to ?mixed
      Open

                  $labelsByThesaurusId[$currentTerm['thesaurus_id']][] = $label;
      Severity: Minor
      Found in src/module-elasticsuite-thesaurus/Model/ResourceModel/Thesaurus/Collection.php by phan

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private function addTermExportData($termData)
    {
        $labelsByThesaurusId = [];

        foreach ($termData as $currentTerm) {
      Severity: Major
      Found in src/module-elasticsuite-thesaurus/Model/ResourceModel/Thesaurus/Collection.php and 1 other location - About 4 hrs to fix
      src/module-elasticsuite-thesaurus/Model/ResourceModel/Thesaurus/Collection.php on lines 333..352

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 132.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private function addTermData($termData)
    {
        $labelsByThesaurusId = [];

        foreach ($termData as $currentTerm) {
      Severity: Major
      Found in src/module-elasticsuite-thesaurus/Model/ResourceModel/Thesaurus/Collection.php and 1 other location - About 4 hrs to fix
      src/module-elasticsuite-thesaurus/Model/ResourceModel/Thesaurus/Collection.php on lines 361..380

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 132.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  $this->getSelect()->join(
                ['store_table' => $this->getTable(ThesaurusInterface::STORE_TABLE_NAME)],
                'main_table.' . ThesaurusInterface::THESAURUS_ID . ' = store_table.' . ThesaurusInterface::THESAURUS_ID,
                []
            )->group(
      Severity: Major
      Found in src/module-elasticsuite-thesaurus/Model/ResourceModel/Thesaurus/Collection.php and 1 other location - About 1 hr to fix
      src/module-elasticsuite-thesaurus/Model/ResourceModel/Thesaurus/Collection.php on lines 142..148

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              $this->getSelect()
            ->join(
                ['store_table' => $this->getTable(ThesaurusInterface::STORE_TABLE_NAME)],
                'main_table.' . ThesaurusInterface::THESAURUS_ID . ' = store_table.' . ThesaurusInterface::THESAURUS_ID,
                []
      Severity: Major
      Found in src/module-elasticsuite-thesaurus/Model/ResourceModel/Thesaurus/Collection.php and 1 other location - About 1 hr to fix
      src/module-elasticsuite-thesaurus/Model/ResourceModel/Thesaurus/Collection.php on lines 162..168

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          public function setStoreId($store)
    {
        if ($store instanceof Store) {
            $store = $store->getId();
        }
      Severity: Minor
      Found in src/module-elasticsuite-thesaurus/Model/ResourceModel/Thesaurus/Collection.php and 1 other location - About 30 mins to fix
      src/module-elasticsuite-catalog-optimizer/Model/ResourceModel/Optimizer/Collection.php on lines 74..82

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status