Smile-SA/elasticsuite

View on GitHub
src/module-elasticsuite-tracker/Model/Data/Checker/Event/UndefinedSessionId.php

Summary

Maintainability
B
5 hrs
Test Coverage

Showing 4 of 4 total issues

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

DataCheckResultFactory $checkResultFactory,
Builder $searchRequestBuilder,
QueryFactory $queryFactory,
SearchEngineInterface $searchEngine,
?DataFixerInterface $dataFixer = null

    Argument 5 (query) is null but \Smile\ElasticsuiteCore\Search\Request\Builder::create() takes \Smile\ElasticsuiteCore\Search\Request\QueryInterface|string defined at /code/src/module-elasticsuite-core/Search/Request/Builder.php:136
    Open

    return $this->searchRequestBuilder->create($storeId, EventIndexInterface::INDEX_IDENTIFIER, 0, 0, null, [], [], $queryFilters);

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    public function check($storeId): DataCheckResult
    {
    /** @var DataCheckResult $checkResult */
    $checkResult = $this->checkResultFactory->create([]);
     
     
    src/module-elasticsuite-tracker/Model/Data/Checker/Session/UndefinedSessionId.php on lines 83..99

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    $this->queryFactory->create(
    QueryInterface::TYPE_BOOL,
    [
    'should' => [
    $this->queryFactory->create(QueryInterface::TYPE_MISSING, ['field' => 'session.uid']),
    src/module-elasticsuite-tracker/Model/Data/Fixer/Event/DeleteUndefinedSessionId.php on lines 90..98

    There are no issues that match your filters.

    Category
    Status