Sign upLogin

Smile-SA/elasticsuite

View on GitHub
Star
src/module-elasticsuite-virtual-category/Controller/Router.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        ActionFactory $actionFactory,
        ManagerInterface $eventManager,
        StoreManagerInterface $storeManager,
        Url $urlModel,
        VirtualCategoryRoot $virtualCategoryRoot
Severity: Minor
Found in src/module-elasticsuite-virtual-category/Controller/Router.php - About 35 mins to fix

    Avoid too many return statements within this method.
    Open

            return $action;
    Severity: Minor
    Found in src/module-elasticsuite-virtual-category/Controller/Router.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return $this->actionFactory->create('Magento\Framework\App\Action\Forward');
      Severity: Minor
      Found in src/module-elasticsuite-virtual-category/Controller/Router.php - About 30 mins to fix

        Returning type \Magento\Framework\DataObject but getAppliedVirtualCategoryRoot() is declared to return \Magento\Catalog\Api\Data\CategoryInterface
        Open

                return $this->virtualCategoryRoot->getByUrlKeys($urlKeys);
        Severity: Minor
        Found in src/module-elasticsuite-virtual-category/Controller/Router.php by phan

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

            public function __construct(
        ActionFactory $actionFactory,
        ManagerInterface $eventManager,
        StoreManagerInterface $storeManager,
        Url $urlModel,
        Severity: Major
        Found in src/module-elasticsuite-virtual-category/Controller/Router.php and 5 other locations - About 1 hr to fix
        src/module-elasticsuite-catalog/Plugin/Ui/Category/Form/DataProviderPlugin.php on lines 77..89
        src/module-elasticsuite-core/Model/DataProvider/Suggestions.php on lines 76..88
        src/module-elasticsuite-core/Model/Search/Request/RelevanceConfig/Reader/ContainerStore.php on lines 66..78
        src/module-elasticsuite-core/Search/Request/SortOrder/SortOrderBuilder.php on lines 69..81
        src/module-elasticsuite-tracker/Observer/TrackRedirectIfOneResult.php on lines 65..77

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 84.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status