Sign upLogin

Smile-SA/elasticsuite

View on GitHub
Star
src/module-elasticsuite-virtual-category/Model/Preview.php

Summary

Maintainability
A
2 hrs
Test Coverage

Function getQueryFilter has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    private function getQueryFilter(): ?QueryInterface
    {
        $query = null;

        $this->category->setIsActive(true);
Severity: Minor
Found in src/module-elasticsuite-virtual-category/Model/Preview.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

        CategoryInterface $category,
        FulltextCollectionFactory $productCollectionFactory,
        ItemDataFactory $previewItemFactory,
        QueryFactory $queryFactory,
        ContextInterface $searchContext,
Severity: Major
Found in src/module-elasticsuite-virtual-category/Model/Preview.php - About 1 hr to fix

    Doc-block of $categoryConfig in __construct is phpdoc param type \Magento\Catalog\Model\Config which is not a permitted replacement of the nullable param type ?\Magento\Catalog\Model\Config declared in the signature ('?T' should be documented as 'T|null' or '?T')
    Open

         * @param Config                    $categoryConfig           Category config.
    Severity: Minor
    Found in src/module-elasticsuite-virtual-category/Model/Preview.php by phan

    Doc-block of $request in __construct is phpdoc param type \Magento\Framework\App\RequestInterface which is not a permitted replacement of the nullable param type ?\Magento\Framework\App\RequestInterface declared in the signature ('?T' should be documented as 'T|null' or '?T')
    Open

         * @param RequestInterface          $request                  HTTP Request.
    Severity: Minor
    Found in src/module-elasticsuite-virtual-category/Model/Preview.php by phan

    Doc-block of getQueryFilter has declared return type \Smile\ElasticsuiteCore\Search\Request\QueryInterface which is not a permitted replacement of the nullable return type ?\Smile\ElasticsuiteCore\Search\Request\QueryInterface declared in the signature ('?T' should be documented as 'T|null' or '?T')
    Open

         * @return QueryInterface
    Severity: Minor
    Found in src/module-elasticsuite-virtual-category/Model/Preview.php by phan

    There are no issues that match your filters.

    Category
    Status