Sign upLogin

Smile-SA/elasticsuite

View on GitHub
Star
src/module-elasticsuite-virtual-category/Model/Url.php

Summary

Maintainability
B
6 hrs
Test Coverage

Url has 13 functions (exceeds 10 allowed). Consider refactoring.
Open

class Url
{
    /**
     * XML path for product url suffix
     */
Severity: Minor
Found in src/module-elasticsuite-virtual-category/Model/Url.php - About 2 hrs to fix

    Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            ScopeConfigInterface $scopeConfig,
        StoreManagerInterface $storeManager,
        CategoryCollectionFactory $categoryCollectionFactory,
        UrlFinderInterface $urlFinder,
        UrlInterface $urlBuilder,
    Severity: Minor
    Found in src/module-elasticsuite-virtual-category/Model/Url.php - About 45 mins to fix

      Function getProductRewrite has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getProductRewrite($productRequestPath, $categoryRequestPath, $storeId = null): ?UrlRewrite
    {
        $productRewrite = null;
        if (null === $storeId) {
            $storeId = $this->storeManager->getStore()->getId();
      Severity: Minor
      Found in src/module-elasticsuite-virtual-category/Model/Url.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Argument 1 (appliedRootCategory) is \Magento\Catalog\Model\Category|null but \Smile\ElasticsuiteVirtualCategory\Model\VirtualCategory\Root::getVirtualCategorySubtreePath() takes \Magento\Catalog\Api\Data\CategoryInterface defined at /code/src/module-elasticsuite-virtual-category/Model/VirtualCategory/Root.php:110
      Open

                      $this->virtualCategoryRoot->getAppliedRootCategory(),
      Severity: Minor
      Found in src/module-elasticsuite-virtual-category/Model/Url.php by phan

      Argument 2 (childCategory) is \Smile\ElasticsuiteVirtualCategory\Model\Category but \Smile\ElasticsuiteVirtualCategory\Model\VirtualCategory\Root::getVirtualCategorySubtreePath() takes \Magento\Catalog\Api\Data\CategoryInterface defined at /code/src/module-elasticsuite-virtual-category/Model/VirtualCategory/Root.php:110
      Open

                      $category
      Severity: Minor
      Found in src/module-elasticsuite-virtual-category/Model/Url.php by phan

      Assigning \Smile\ElasticsuiteVirtualCategory\Model\ResourceModel\VirtualCategory\CollectionFactory to property but \Smile\ElasticsuiteVirtualCategory\Model\Url->categoryCollectionFactory is \Magento\Catalog\Model\ResourceModel\Category\CollectionFactory
      Open

              $this->categoryCollectionFactory = $categoryCollectionFactory;
      Severity: Minor
      Found in src/module-elasticsuite-virtual-category/Model/Url.php by phan

      Doc-block of getProductRequestPath has declared return type string which is not a permitted replacement of the nullable return type ?string declared in the signature ('?T' should be documented as 'T|null' or '?T')
      Open

           * @return string
      Severity: Minor
      Found in src/module-elasticsuite-virtual-category/Model/Url.php by phan

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

          public function __construct(
        ScopeConfigInterface $scopeConfig,
        StoreManagerInterface $storeManager,
        CategoryCollectionFactory $categoryCollectionFactory,
        UrlFinderInterface $urlFinder,
      Severity: Major
      Found in src/module-elasticsuite-virtual-category/Model/Url.php and 5 other locations - About 2 hrs to fix
      src/module-elasticsuite-catalog-optimizer/Model/Optimizer/Preview/RequestBuilder.php on lines 73..87
      src/module-elasticsuite-catalog/Block/Plugin/Adminhtml/Product/Attribute/Edit/Tab/FrontPlugin.php on lines 92..106
      src/module-elasticsuite-catalog/Model/Import/ProductAttribute.php on lines 111..125
      src/module-elasticsuite-tracker/Model/ResourceModel/EventIndex/DateBounds.php on lines 78..92
      src/module-elasticsuite-virtual-category/Plugin/Widget/ProductsListPlugin.php on lines 79..93

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 100.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status