Sobak/scrawler

View on GitHub

Showing 7 of 7 total issues

Function processResponse has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    protected function processResponse(ResponseInterface $response): void
    {
        $responseBody = $response->getBody()->getContents();

        if (empty(Utils::trimWhitespace($responseBody))) {
Severity: Minor
Found in src/Scrawler.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method processResponse has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function processResponse(ResponseInterface $response): void
    {
        $responseBody = $response->getBody()->getContents();

        if (empty(Utils::trimWhitespace($responseBody))) {
Severity: Minor
Found in src/Scrawler.php - About 2 hrs to fix

    Function makeRequest has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function makeRequest(Client $client, Url $url): void
        {
            $canonicalUrl = $url->getUrl();
    
            $this->visitedUrls[$canonicalUrl] = true;
    Severity: Minor
    Found in src/Scrawler.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method makeRequest has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function makeRequest(Client $client, Url $url): void
        {
            $canonicalUrl = $url->getUrl();
    
            $this->visitedUrls[$canonicalUrl] = true;
    Severity: Minor
    Found in src/Scrawler.php - About 1 hr to fix

      Function execute has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function execute(InputInterface $input, OutputInterface $output): int
          {
              $configurationPath = $input->getArgument('config');
              $outputPath = $input->getOption('output');
      
      
      Severity: Minor
      Found in src/Application/Commands/CrawlCommand.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function normalizeUrl has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function normalizeUrl(string $url, ?string $currentUrl)
          {
              if ($currentUrl === null) {
                  if (parse_url($url, PHP_URL_SCHEME) === null) {
                      throw new \Exception('First URL must be absolute');
      Severity: Minor
      Found in src/Client/Response/Elements/Url.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                      return '%s';
      Severity: Major
      Found in src/Block/LogWriter/ConsoleLogWriter.php - About 30 mins to fix
        Severity
        Category
        Status
        Source
        Language