Sign upLogin

SockDrawer/SockBot

View on GitHub
Star

Showing 31 of 31 total issues

Function quoteText has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

exports.quoteText = function quoteText(text, quotedUser, contextUrl, contextTitle) {
    const quote = stringify(text),
        user = stringify(quotedUser),
        url = stringify(contextUrl),
        title = stringify(contextTitle);
Severity: Minor
Found in providers/nodebb/format.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        lock() {
            return forum._emit('topics.lock', {
                tids: [this.id],
                cid: this.categoryId
            })
Severity: Minor
Found in providers/nodebb/topic.js and 1 other location - About 50 mins to fix
providers/nodebb/topic.js on lines 381..387

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        unlock() {
            return forum._emit('topics.unlock', {
                tids: [this.id],
                cid: this.categoryId
            })
Severity: Minor
Found in providers/nodebb/topic.js and 1 other location - About 50 mins to fix
providers/nodebb/topic.js on lines 362..368

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function validateConfig has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

exports.validateConfig = function validateConfig(config) {
    const errors = [];
    const checkSection = (key) => {
        if (typeof config[key] !== 'object') {
            errors.push(`Missing configuration section: ${key}`);
Severity: Minor
Found in lib/config.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function threeParts has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

function threeParts(before, item1, defaultItem1, middle, item2, after) {
Severity: Minor
Found in providers/nodebb/format.js - About 45 mins to fix

Function getVersion has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

exports.getVersion = function getVersion() {
    if (packageInfo.version !== '0.0.0-semantic-release') {
        return packageInfo.version;
    }
    const parser = /\$Id: (\S+) \$/;
Severity: Minor
Found in lib/app.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parseJSON has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

exports.parseJSON = function parseJSON(json) {
    if (!json) {
        throw new Error('[[invalid-argument:required]]');
    }
    if (typeof json === 'string') {
Severity: Minor
Found in lib/utils.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function relativeRequire has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

exports.relativeRequire = function relativeRequire(relativePath, module, requireIt) {
    let resolved = `${__dirname}/../${relativePath}/${module}`;
    if (module.startsWith('/') || module.startsWith('./') || module.startsWith('../')) {
        resolved = path.posix.resolve(config.basePath, module);
    }
Severity: Minor
Found in lib/app.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function load has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

exports.load = function load(filePath) {
    return readYaml(filePath)
        .then((data) => {
            if (!data) {
                throw new Error('Invalid Configuration File.');
Severity: Minor
Found in lib/config.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _emitWithRetry has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    _emitWithRetry(delay) {
        let trials = 5;
        const args = Array.prototype.slice.call(arguments);
        args.shift(); // remove the delay parameter
        const fn = () => new Promise((resolve, reject) => {
Severity: Minor
Found in providers/nodebb/index.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function bindPost has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

exports.bindPost = function bindPost(forum) {
    /**
     * Post Class
     *
     * Represents a forum post
Severity: Minor
Found in providers/nodebb/post.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language