Soyhuce/l5-repository

View on GitHub

Showing 38 of 38 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace Prettus\Repository\Generators;

use Prettus\Repository\Generators\Migrations\SchemaParser;
src/Prettus/Repository/Generators/ModelGenerator.php on lines 1..106

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 230.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace Prettus\Repository\Generators;

use Prettus\Repository\Generators\Migrations\SchemaParser;
Severity: Major
Found in src/Prettus/Repository/Generators/ModelGenerator.php and 1 other location - About 1 day to fix
src/Prettus/Repository/Generators/RepositoryInterfaceGenerator.php on lines 1..105

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 230.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

BaseRepository has 49 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class BaseRepository implements RepositoryInterface, RepositoryCriteriaInterface
{

    /**
     * @var Application
Severity: Minor
Found in src/Prettus/Repository/Eloquent/BaseRepository.php - About 6 hrs to fix

    File BaseRepository.php has 436 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    namespace Prettus\Repository\Eloquent;
    
    use Exception;
    use Illuminate\Container\Container as Application;
    Severity: Minor
    Found in src/Prettus/Repository/Eloquent/BaseRepository.php - About 6 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      <?php
      namespace Prettus\Repository\Generators\Commands;
      
      use Illuminate\Console\Command;
      use Prettus\Repository\Generators\FileAlreadyExistsException;
      src/Prettus/Repository/Generators/Commands/CriteriaCommand.php on lines 1..90

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 159.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      <?php
      
      namespace Prettus\Repository\Generators\Commands;
      
      use Illuminate\Console\Command;
      src/Prettus/Repository/Generators/Commands/TransformerCommand.php on lines 1..90

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 159.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method apply has 103 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function apply($model, RepositoryInterface $repository)
          {
              $fieldsSearchable = $repository->getFieldsSearchable();
              $search = $this->request->get(config('repository.criteria.params.search', 'search'), null);
              $searchFields = $this->request->get(config('repository.criteria.params.searchFields', 'searchFields'), null);
      Severity: Major
      Found in src/Prettus/Repository/Criteria/RequestCriteria.php - About 4 hrs to fix

        Function parserFieldsSearch has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function parserFieldsSearch(array $fields = [], array $searchFields = null)
            {
                if (!is_null($searchFields) && count($searchFields)) {
                    $acceptedConditions = config(
                        'repository.criteria.acceptedConditions',
        Severity: Minor
        Found in src/Prettus/Repository/Criteria/RequestCriteria.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            public function getOptions()
            {
                return [
                    [
                        'fillable',
        Severity: Major
        Found in src/Prettus/Repository/Generators/Commands/EntityCommand.php and 1 other location - About 2 hrs to fix
        src/Prettus/Repository/Generators/Commands/RepositoryCommand.php on lines 135..167

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 116.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            public function getOptions()
            {
                return [
                    [
                        'fillable',
        src/Prettus/Repository/Generators/Commands/EntityCommand.php on lines 119..151

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 116.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function makePresenter($presenter = null)
            {
                $presenter = !is_null($presenter) ? $presenter : $this->presenter();
        
                if (!is_null($presenter)) {
        Severity: Major
        Found in src/Prettus/Repository/Eloquent/BaseRepository.php and 1 other location - About 2 hrs to fix
        src/Prettus/Repository/Eloquent/BaseRepository.php on lines 213..228

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 113.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function makeValidator($validator = null)
            {
                $validator = !is_null($validator) ? $validator : $this->validator();
        
                if (!is_null($validator)) {
        Severity: Major
        Found in src/Prettus/Repository/Eloquent/BaseRepository.php and 1 other location - About 2 hrs to fix
        src/Prettus/Repository/Eloquent/BaseRepository.php on lines 190..205

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 113.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function find($id, $columns = ['*'])
            {
                if (!$this->allowedCache('find') || $this->isSkippedCache()) {
                    return parent::find($id, $columns);
                }
        Severity: Major
        Found in src/Prettus/Repository/Traits/CacheableRepository.php and 1 other location - About 2 hrs to fix
        src/Prettus/Repository/Traits/CacheableRepository.php on lines 314..331

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 111.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function findWhere(array $where, $columns = ['*'])
            {
                if (!$this->allowedCache('findWhere') || $this->isSkippedCache()) {
                    return parent::findWhere($where, $columns);
                }
        Severity: Major
        Found in src/Prettus/Repository/Traits/CacheableRepository.php and 1 other location - About 2 hrs to fix
        src/Prettus/Repository/Traits/CacheableRepository.php on lines 259..276

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 111.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function findByField($field, $value = null, $columns = ['*'])
            {
                if (!$this->allowedCache('findByField') || $this->isSkippedCache()) {
                    return parent::findByField($field, $value, $columns);
                }
        Severity: Major
        Found in src/Prettus/Repository/Traits/CacheableRepository.php and 1 other location - About 2 hrs to fix
        src/Prettus/Repository/Traits/CacheableRepository.php on lines 231..249

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 108.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function paginate($limit = null, $columns = ['*'], $method = "paginate")
            {
                if (!$this->allowedCache('paginate') || $this->isSkippedCache()) {
                    return parent::paginate($limit, $columns, $method);
                }
        Severity: Major
        Found in src/Prettus/Repository/Traits/CacheableRepository.php and 1 other location - About 2 hrs to fix
        src/Prettus/Repository/Traits/CacheableRepository.php on lines 287..304

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 108.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Generator has 22 functions (exceeds 20 allowed). Consider refactoring.
        Open

        abstract class Generator
        {
        
            /**
             * The filesystem instance.
        Severity: Minor
        Found in src/Prettus/Repository/Generators/Generator.php - About 2 hrs to fix

          Method fire has 53 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function fire()
              {
                  $this->generators = new Collection();
          
                  $this->generators->push(
          Severity: Major
          Found in src/Prettus/Repository/Generators/Commands/RepositoryCommand.php - About 2 hrs to fix

            Function apply has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
            Open

                public function apply($model, RepositoryInterface $repository)
                {
                    $fieldsSearchable = $repository->getFieldsSearchable();
                    $search = $this->request->get(config('repository.criteria.params.search', 'search'), null);
                    $searchFields = $this->request->get(config('repository.criteria.params.searchFields', 'searchFields'), null);
            Severity: Minor
            Found in src/Prettus/Repository/Criteria/RequestCriteria.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method fire has 49 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function fire()
                {
            
                    if ($this->confirm('Would you like to create a Presenter? [y|N]')) {
                        $this->call(
            Severity: Minor
            Found in src/Prettus/Repository/Generators/Commands/EntityCommand.php - About 1 hr to fix
              Severity
              Category
              Status
              Source
              Language