Sign upLogin

SpamExperts/OrangeAssassin

View on GitHub
Star
oa/plugins/body_eval.py

Summary

Maintainability
A
1 hr
Test Coverage

Cyclomatic complexity is too high in method extract_metadata. (13)
Open

    def extract_metadata(self, msg, payload, text, part):
        """Parse each part and extract the relevant tokens."""
        super(BodyEval, self).extract_metadata(msg, payload, text, part)
        multiparts = self.get_local(msg, "multiparts")
        if part.get_content_type() == "multipart/alternative":
Severity: Minor
Found in oa/plugins/body_eval.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function check_blank_line_ratio has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def check_blank_line_ratio(self, msg, minr, maxr, minlines=1, target=None):
Severity: Minor
Found in oa/plugins/body_eval.py - About 35 mins to fix

    XXX found
    Open

        # XXX Strange name?
    Severity: Minor
    Found in oa/plugins/body_eval.py by fixme

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    STOCK_RE = Regex(r"""
    ^trad(?:e|ing)date|
    company(?:name)?|
    s\w?(?:t\w?o\w?c\w?k|y\w?m(?:\w?b\w?o\w?l)?)|
    t(?:arget|icker)|
    Severity: Major
    Found in oa/plugins/body_eval.py and 4 other locations - About 50 mins to fix
    oa/networks.py on lines 9..19
    oa/plugins/spf.py on lines 13..17
    oa/plugins/spf.py on lines 18..18
    oa/plugins/spf.py on lines 19..23

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 36.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status