Sign upLogin

SpamExperts/whmcs-addon

View on GitHub
Star

Showing 72 of 72 total issues

Function slide has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  , slide: function (type, next) {
      var $active = this.$element.find('.item.active')
        , $next = next || $active[type]()
        , isCycling = this.interval
        , direction = type == 'next' ? 'left' : 'right'
Severity: Minor
Found in modules/addons/spamexperts/core/assets/js/bootstrap.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    function kwspamexperts_UnsuspendAccount($params)
{
    $domain   = !empty($params["customfields"]["Domain"])   ? $params["customfields"]["Domain"] : $params['domain'];
        $api = new kwspamexperts_api($params);
        if(empty($domain)){
    Severity: Major
    Found in modules/servers/kwspamexperts/kwspamexperts.php and 1 other location - About 1 hr to fix
    modules/servers/kwspamexperts/kwspamexperts.php on lines 175..191

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 109.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    function kwspamexperts_SuspendAccount($params)
{
    $domain   = !empty($params["customfields"]["Domain"])   ? $params["customfields"]["Domain"] : $params['domain'];
        $api = new kwspamexperts_api($params);
    Severity: Major
    Found in modules/servers/kwspamexperts/kwspamexperts.php and 1 other location - About 1 hr to fix
    modules/servers/kwspamexperts/kwspamexperts.php on lines 193..208

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 109.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

             if(!empty($_SESSION['Language']))
             $language = strtolower($_SESSION['Language']);
         else if(isset($params['clientsdetails']['language']) && strtolower($params['clientsdetails']['language'])!='')
             $language = strtolower($params['clientsdetails']['language']);
         else
    Severity: Major
    Found in modules/servers/kwspamexperts/spamexpertsreseller.php and 2 other locations - About 1 hr to fix
    modules/servers/kwspamexperts/kwspamexperts.php on lines 219..224
    modules/servers/spamexpertsreseller/spamexpertsreseller.php on lines 209..214

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

            if(!empty($_SESSION['Language']))
            $language = strtolower($_SESSION['Language']);
        else if(isset($params['clientsdetails']['language']) && strtolower($params['clientsdetails']['language'])!='')
            $language = strtolower($params['clientsdetails']['language']);
        else
    Severity: Major
    Found in modules/servers/spamexpertsreseller/spamexpertsreseller.php and 2 other locations - About 1 hr to fix
    modules/servers/kwspamexperts/kwspamexperts.php on lines 219..224
    modules/servers/kwspamexperts/spamexpertsreseller.php on lines 210..215

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

            if(!empty($_SESSION['Language']))
            $language = strtolower($_SESSION['Language']);
        else if(isset($params['clientsdetails']['language']) && strtolower($params['clientsdetails']['language'])!='')
            $language = strtolower($params['clientsdetails']['language']);
        else
    Severity: Major
    Found in modules/servers/kwspamexperts/kwspamexperts.php and 2 other locations - About 1 hr to fix
    modules/servers/kwspamexperts/spamexpertsreseller.php on lines 210..215
    modules/servers/spamexpertsreseller/spamexpertsreseller.php on lines 209..214

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method spamexpertsreseller_ConfigOptions has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function spamexpertsreseller_ConfigOptions()
{
    $configarray = array(
        "SpampanelURL"     => array(
            "Type"         => "text",
    Severity: Minor
    Found in modules/servers/spamexpertsreseller/spamexpertsreseller.php - About 1 hr to fix

      Method spamexpertsreseller_ConfigOptions has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function spamexpertsreseller_ConfigOptions() 
{
    $configarray = array(
     "SpampanelURL"     => array(
             "Type"         => "text",
      Severity: Minor
      Found in modules/servers/kwspamexperts/spamexpertsreseller.php - About 1 hr to fix

        Method kwspamexperts_CreateAccount has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function kwspamexperts_CreateAccount($params)
{
    $api        = new kwspamexperts_api($params);
    $domain     = !empty($params["customfields"]["Domain"])  ? $params["customfields"]["Domain"] : $params['domain'];
    $password   = !empty($params['password'])                ? $params["password"]               : createServerPassword();
        Severity: Minor
        Found in modules/servers/kwspamexperts/kwspamexperts.php - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if(isset($_POST['adminemail'])){
        $api->call('domainadmincontact/set/domain/'.$domain.'/email/'.$_POST['adminemail'].'/');
        if ($api->isSuccess())
            $vars['_status'] = array('code'=>1,'msg'=>$vars['lang']['email_changed']);
        else
          Severity: Major
          Found in modules/servers/kwspamexperts/EditEmail.php and 1 other location - About 1 hr to fix
          modules/servers/kwspamexperts/EditEmail.php on lines 33..40

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if(isset($_POST['primaryemail'])){

        $api->call('domaincontact/set/domain/'.$domain.'/email/'.$_POST['primaryemail'].'/');
        if ($api->isSuccess())
            $vars['_status'] = array('code'=>1,'msg'=>$vars['lang']['email_changed']);
          Severity: Major
          Found in modules/servers/kwspamexperts/EditEmail.php and 1 other location - About 1 hr to fix
          modules/servers/kwspamexperts/EditEmail.php on lines 42..48

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method kwspamexperts_management has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

               function kwspamexperts_management($params){
         global $CONFIG;
         $lang              = kwspamexperts_getLang($params);
         $api               = new kwspamexperts_api($params);
         $page              = (isset($_GET['page'])                      ? addslashes($_GET['page'])          : 'mainsite');
          Severity: Minor
          Found in modules/servers/kwspamexperts/kwspamexperts.php - About 1 hr to fix

            Method spamexpertsreseller_management has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                 function spamexpertsreseller_management($params){
         // phpcs:ignore PHPCS_SecurityAudit.BadFunctions.EasyRFI.WarnEasyRFI
         include_once(__DIR__.DIRECTORY_SEPARATOR.'class.connection.php');
         global $CONFIG;    
         $lang              = spamexpertsreseller_getLang($params);
            Severity: Minor
            Found in modules/servers/kwspamexperts/spamexpertsreseller.php - About 1 hr to fix

              Method spamexpertsreseller_management has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                   function spamexpertsreseller_management($params){
         // phpcs:ignore PHPCS_SecurityAudit.BadFunctions.EasyRFI.WarnEasyRFI
         include_once(__DIR__.DIRECTORY_SEPARATOR.'class.connection.php');
         global $CONFIG;    
         $lang              = spamexpertsreseller_getLang($params);
              Severity: Minor
              Found in modules/servers/spamexpertsreseller/spamexpertsreseller.php - About 1 hr to fix

                Function show has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    , show: function () {
        var that = this
          , e = $.Event('show')

        this.$element.trigger(e)
                Severity: Minor
                Found in modules/addons/spamexperts/core/assets/js/bootstrap.js - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function addError($line)
    {
        // phpcs:ignore PHPCS_SecurityAudit.BadFunctions.FilesystemFunctions.WarnFilesystem
        if(!file_exists(($filename = $this->settings['error_file'])))
        {
                  Severity: Major
                  Found in modules/addons/spamexperts/core/logger/FileLogger.php and 1 other location - About 1 hr to fix
                  modules/addons/spamexperts/core/logger/FileLogger.php on lines 35..50

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 101.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function addInfo($line)
    {
        // phpcs:ignore PHPCS_SecurityAudit.BadFunctions.FilesystemFunctions.WarnFilesystem
        if(!file_exists(($filename = $this->settings['info_file'])))
        {
                  Severity: Major
                  Found in modules/addons/spamexperts/core/logger/FileLogger.php and 1 other location - About 1 hr to fix
                  modules/addons/spamexperts/core/logger/FileLogger.php on lines 56..71

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 101.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                        this.timeout = setTimeout(function() {
        if (self.hoverState == 'in') self.show()
      }, self.options.delay.show)
                  Severity: Major
                  Found in modules/addons/spamexperts/core/assets/js/bootstrap.js and 1 other location - About 1 hr to fix
                  modules/addons/spamexperts/core/assets/js/bootstrap.js on lines 1055..1057

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 55.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                        this.timeout = setTimeout(function() {
        if (self.hoverState == 'out') self.hide()
      }, self.options.delay.hide)
                  Severity: Major
                  Found in modules/addons/spamexperts/core/assets/js/bootstrap.js and 1 other location - About 1 hr to fix
                  modules/addons/spamexperts/core/assets/js/bootstrap.js on lines 1043..1045

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 55.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          this.$element.on(eventOut + '.' + this.type, this.options.selector, $.proxy(this.leave, this))
                  Severity: Minor
                  Found in modules/addons/spamexperts/core/assets/js/bootstrap.js and 1 other location - About 45 mins to fix
                  modules/addons/spamexperts/core/assets/js/bootstrap.js on lines 1014..1014

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 50.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language