Sign upLogin

SpamExperts/whmcs-addon

View on GitHub
Star
modules/servers/kwspamexperts/kwspamexperts.php

Summary

Maintainability
C
1 day
Test Coverage

Function kwspamexperts_getLang has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    function kwspamexperts_getLang($params){
        global $CONFIG;
        if(!empty($_SESSION['Language']))
            $language = strtolower($_SESSION['Language']);
        else if(isset($params['clientsdetails']['language']) && strtolower($params['clientsdetails']['language'])!='')
Severity: Minor
Found in modules/servers/kwspamexperts/kwspamexperts.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method kwspamexperts_ConfigOptions has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function kwspamexperts_ConfigOptions() {
    $configarray = array(
     "ProductType"      => array(
             "Type"         => "dropdown",
             "Options"      => "Incoming,Outgoing,Both",
Severity: Minor
Found in modules/servers/kwspamexperts/kwspamexperts.php - About 1 hr to fix

    Method kwspamexperts_CreateAccount has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function kwspamexperts_CreateAccount($params)
{
    $api        = new kwspamexperts_api($params);
    $domain     = !empty($params["customfields"]["Domain"])  ? $params["customfields"]["Domain"] : $params['domain'];
    $password   = !empty($params['password'])                ? $params["password"]               : createServerPassword();
    Severity: Minor
    Found in modules/servers/kwspamexperts/kwspamexperts.php - About 1 hr to fix

      Method kwspamexperts_management has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

           function kwspamexperts_management($params){
         global $CONFIG;
         $lang              = kwspamexperts_getLang($params);
         $api               = new kwspamexperts_api($params);
         $page              = (isset($_GET['page'])                      ? addslashes($_GET['page'])          : 'mainsite');
      Severity: Minor
      Found in modules/servers/kwspamexperts/kwspamexperts.php - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                return $res;
        Severity: Major
        Found in modules/servers/kwspamexperts/kwspamexperts.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

              return "success";
          Severity: Major
          Found in modules/servers/kwspamexperts/kwspamexperts.php - About 30 mins to fix

            Function kwspamexperts_CreateAccount has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            function kwspamexperts_CreateAccount($params)
{
    $api        = new kwspamexperts_api($params);
    $domain     = !empty($params["customfields"]["Domain"])  ? $params["customfields"]["Domain"] : $params['domain'];
    $password   = !empty($params['password'])                ? $params["password"]               : createServerPassword();
            Severity: Minor
            Found in modules/servers/kwspamexperts/kwspamexperts.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            function kwspamexperts_UnsuspendAccount($params)
{
    $domain   = !empty($params["customfields"]["Domain"])   ? $params["customfields"]["Domain"] : $params['domain'];
        $api = new kwspamexperts_api($params);
        if(empty($domain)){
            Severity: Major
            Found in modules/servers/kwspamexperts/kwspamexperts.php and 1 other location - About 1 hr to fix
            modules/servers/kwspamexperts/kwspamexperts.php on lines 175..191

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 109.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            function kwspamexperts_SuspendAccount($params)
{
    $domain   = !empty($params["customfields"]["Domain"])   ? $params["customfields"]["Domain"] : $params['domain'];
        $api = new kwspamexperts_api($params);
            Severity: Major
            Found in modules/servers/kwspamexperts/kwspamexperts.php and 1 other location - About 1 hr to fix
            modules/servers/kwspamexperts/kwspamexperts.php on lines 193..208

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 109.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                    if(!empty($_SESSION['Language']))
            $language = strtolower($_SESSION['Language']);
        else if(isset($params['clientsdetails']['language']) && strtolower($params['clientsdetails']['language'])!='')
            $language = strtolower($params['clientsdetails']['language']);
        else
            Severity: Major
            Found in modules/servers/kwspamexperts/kwspamexperts.php and 2 other locations - About 1 hr to fix
            modules/servers/kwspamexperts/spamexpertsreseller.php on lines 210..215
            modules/servers/spamexpertsreseller/spamexpertsreseller.php on lines 209..214

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 108.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status