Sign upLogin

SpamExperts/whmcs-addon

View on GitHub
Star
modules/servers/kwspamexperts/spamexpertsreseller.php

Summary

Maintainability
F
5 days
Test Coverage

Function spamexpertsreseller_getLang has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    function spamexpertsreseller_getLang($params){
         global $CONFIG;
         if(!empty($_SESSION['Language']))
             $language = strtolower($_SESSION['Language']);
         else if(isset($params['clientsdetails']['language']) && strtolower($params['clientsdetails']['language'])!='')
Severity: Minor
Found in modules/servers/kwspamexperts/spamexpertsreseller.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method spamexpertsreseller_ConfigOptions has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function spamexpertsreseller_ConfigOptions() 
{
    $configarray = array(
     "SpampanelURL"     => array(
             "Type"         => "text",
Severity: Minor
Found in modules/servers/kwspamexperts/spamexpertsreseller.php - About 1 hr to fix

    Method spamexpertsreseller_management has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

         function spamexpertsreseller_management($params){
         // phpcs:ignore PHPCS_SecurityAudit.BadFunctions.EasyRFI.WarnEasyRFI
         include_once(__DIR__.DIRECTORY_SEPARATOR.'class.connection.php');
         global $CONFIG;    
         $lang              = spamexpertsreseller_getLang($params);
    Severity: Minor
    Found in modules/servers/kwspamexperts/spamexpertsreseller.php - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      if (!function_exists('spamexpertsreseller_management')){
     function spamexpertsreseller_management($params){
         // phpcs:ignore PHPCS_SecurityAudit.BadFunctions.EasyRFI.WarnEasyRFI
         include_once(__DIR__.DIRECTORY_SEPARATOR.'class.connection.php');
         global $CONFIG;
      Severity: Major
      Found in modules/servers/kwspamexperts/spamexpertsreseller.php and 1 other location - About 1 day to fix
      modules/servers/spamexpertsreseller/spamexpertsreseller.php on lines 253..291

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 386.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      function spamexpertsreseller_CreateAccount($params) 
{
    // phpcs:ignore PHPCS_SecurityAudit.BadFunctions.EasyRFI.WarnEasyRFI
    include_once(__DIR__.DIRECTORY_SEPARATOR.'class.connection.php');
    $api        = new spamexperts_api($params);
      Severity: Major
      Found in modules/servers/kwspamexperts/spamexpertsreseller.php and 1 other location - About 1 day to fix
      modules/servers/spamexpertsreseller/spamexpertsreseller.php on lines 92..119

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 297.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      function spamexpertsreseller_ClientArea($params) {
    $output = array('vars' => array());

    // phpcs:ignore PHPCS_SecurityAudit.BadFunctions.EasyRFI.WarnEasyRFI
    include_once(__DIR__.DIRECTORY_SEPARATOR.'class.connection.php');
      Severity: Major
      Found in modules/servers/kwspamexperts/spamexpertsreseller.php and 1 other location - About 6 hrs to fix
      modules/servers/spamexpertsreseller/spamexpertsreseller.php on lines 173..196

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 214.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      function spamexpertsreseller_ConfigOptions() 
{
    $configarray = array(
     "SpampanelURL"     => array(
             "Type"         => "text",
      Severity: Major
      Found in modules/servers/kwspamexperts/spamexpertsreseller.php and 1 other location - About 3 hrs to fix
      modules/servers/spamexpertsreseller/spamexpertsreseller.php on lines 48..83

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 145.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      function spamexpertsreseller_ChangePackage($params) {
    // phpcs:ignore PHPCS_SecurityAudit.BadFunctions.EasyRFI.WarnEasyRFI
    include_once(__DIR__.DIRECTORY_SEPARATOR.'class.connection.php');
    $api = new spamexperts_api($params);
    // for update, the optional value needed for api_usage matches the config option to disable api access
      Severity: Major
      Found in modules/servers/kwspamexperts/spamexpertsreseller.php and 1 other location - About 2 hrs to fix
      modules/servers/spamexpertsreseller/spamexpertsreseller.php on lines 148..164

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 136.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

               if(!empty($_SESSION['Language']))
             $language = strtolower($_SESSION['Language']);
         else if(isset($params['clientsdetails']['language']) && strtolower($params['clientsdetails']['language'])!='')
             $language = strtolower($params['clientsdetails']['language']);
         else
      Severity: Major
      Found in modules/servers/kwspamexperts/spamexpertsreseller.php and 2 other locations - About 1 hr to fix
      modules/servers/kwspamexperts/kwspamexperts.php on lines 219..224
      modules/servers/spamexpertsreseller/spamexpertsreseller.php on lines 209..214

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 108.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status