Sign upLogin

SpartaHack/SpartaHack-API

View on GitHub
Star
resources/checkin.py

Summary

Maintainability
C
1 day
Test Coverage

Function post has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    def post(self):
        """
        Check users in. Required data: user_id
        """
        def is_minor(application):
Severity: Minor
Found in resources/checkin.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

                        return (f"{user.first_name} {user.last_name} is checked in!!",201,headers)
Severity: Major
Found in resources/checkin.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

                            return (f"{user.first_name} {user.last_name} is already checked in!!",200,headers)
Severity: Major
Found in resources/checkin.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

                            return (f"{user.first_name} {user.last_name} is checked in!! and is also a minor!",201,headers)
Severity: Major
Found in resources/checkin.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

            return (internal_server_error,500,headers)
Severity: Major
Found in resources/checkin.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

                return (internal_server_error, 500, headers)
Severity: Major
Found in resources/checkin.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

                    return (forbidden,403,headers)
Severity: Major
Found in resources/checkin.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

            return (internal_server_error,500,headers)
Severity: Major
Found in resources/checkin.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

            return (not_found,404,headers)
Severity: Major
Found in resources/checkin.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

                            return (f"{user.first_name} {user.last_name} is already checked in!! and is also a minor!",200,headers)
Severity: Major
Found in resources/checkin.py - About 30 mins to fix

There are no issues that match your filters.

Category
Status