Sign upLogin

SpartaHack/SpartaHack-API

View on GitHub
Star
resources/schedule.py

Summary

Maintainability
F
3 days
Test Coverage

Function put has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def put(self,schedule_id):
        """
        Update the hardware. Required data: title, description, time, location
        """
        #check if data from request is serializable
Severity: Minor
Found in resources/schedule.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function post has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def post(self):
        """
        Create new hardware. Required data: item,lender, quantity
        """
        try:
Severity: Minor
Found in resources/schedule.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function delete has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def delete(self,schedule_id):
        """
        DELETE request to delete hardware based on specific hardware_id. This is new from the old api.
        """
        user_status,user = has_admin_privileges()
Severity: Minor
Found in resources/schedule.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

            return (internal_server_error,500,headers)
Severity: Major
Found in resources/schedule.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

                    return (ret,200,headers)
Severity: Major
Found in resources/schedule.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

                return (internal_server_error,500,headers)
Severity: Major
Found in resources/schedule.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

                return (internal_server_error,500,headers)
Severity: Major
Found in resources/schedule.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

                return (Schedule_Schema().dump(ret).data,201 ,headers)
Severity: Major
Found in resources/schedule.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

            return (forbidden,403,headers)
Severity: Major
Found in resources/schedule.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

                return (conflict,409,headers)
Severity: Major
Found in resources/schedule.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

            return(forbidden,403,headers)
Severity: Major
Found in resources/schedule.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

            return (forbidden,403,headers)
Severity: Major
Found in resources/schedule.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

                    return (not_found,404,headers)
Severity: Major
Found in resources/schedule.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

                return (internal_server_error,500,headers)
Severity: Major
Found in resources/schedule.py - About 30 mins to fix

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    def delete(self,schedule_id):
        """
        DELETE request to delete hardware based on specific hardware_id. This is new from the old api.
        """
        user_status,user = has_admin_privileges()
Severity: Major
Found in resources/schedule.py and 4 other locations - About 1 day to fix
resources/announcements.py on lines 83..110
resources/faqs.py on lines 80..108
resources/hardware.py on lines 75..100
resources/sponsors.py on lines 71..98

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 186.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def get(self,schedule_id):
        """
        GET the hardware details based on specific hardware_id
        """
        #using get instead of filter and it is marginally faster than filter
Severity: Major
Found in resources/schedule.py and 1 other location - About 5 hrs to fix
resources/hardware.py on lines 15..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status