Sign upLogin

SpeciesFileGroup/taxonworks

View on GitHub
Star
app/controllers/leads_controller.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class LeadsController has 26 methods (exceeds 20 allowed). Consider refactoring.
Open

class LeadsController < ApplicationController
  include DataControllerConfiguration::ProjectDataControllerConfiguration
  before_action :set_lead, only: %i[
    edit create_for_edit update destroy show show_all show_all_print all_texts
    destroy_couplet insert_couplet delete_couplet duplicate update_meta otus]
Severity: Minor
Found in app/controllers/leads_controller.rb - About 3 hrs to fix

    Method all_texts has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def all_texts
    leads = Lead
      .select(:id, :text, :origin_label)
      .with_project_id(sessions_current_project_id)
      .order(:text)
    Severity: Minor
    Found in app/controllers/leads_controller.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method destroy_couplet has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def destroy_couplet
    respond_to do |format|
      if @lead.parent_id.present?
        if @lead.destroy_couplet
          format.json { head :no_content }
    Severity: Minor
    Found in app/controllers/leads_controller.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    TODO found
    Open

          rescue # TODO: add specifics
    Severity: Minor
    Found in app/controllers/leads_controller.rb by fixme

    There are no issues that match your filters.

    Category
    Status