Sign upLogin

SpeciesFileGroup/taxonworks

View on GitHub
Star
app/models/biological_association/dwc_extensions.rb

Summary

Maintainability
A
1 hr
Test Coverage

TODO found
Open

  # TODO: Generic helper
Severity: Minor
Found in app/models/biological_association/dwc_extensions.rb by fixme

TODO found
Open

      relationshipAccordingTo: :dwc_relationship_according_to, # TODO: DwC.  Needs ID version
Severity: Minor
Found in app/models/biological_association/dwc_extensions.rb by fixme

TODO found
Open

  # TODO: Should reference DOIs, Identifiers,  or identifiers in lieu of short citations
Severity: Minor
Found in app/models/biological_association/dwc_extensions.rb by fixme

TODO found
Open

      relationshipEstablishedDate: :dwc_relationship_established_date, # TODO: DwC needs clarification.
Severity: Minor
Found in app/models/biological_association/dwc_extensions.rb by fixme

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    case t
    when %w{Otu Otu} # Published or nothing
      ApplicationController.helpers.short_sources_tag(sources)
    when %w{CollectionObject Otu} # Assume exists on label
      biological_association_subject.dwc_recorded_by || ApplicationController.helpers.short_sources_tag(sources)
Severity: Minor
Found in app/models/biological_association/dwc_extensions.rb and 1 other location - About 55 mins to fix
app/models/biological_association/dwc_extensions.rb on lines 117..129

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    case t
    when %w{Otu Otu}
      ApplicationController.helpers.short_sources_year_tag(sources)
    when %w{CollectionObject Otu}
      biological_association_subject.dwc_event_date || ApplicationController.helpers.short_sources_year_tag(sources)
Severity: Minor
Found in app/models/biological_association/dwc_extensions.rb and 1 other location - About 55 mins to fix
app/models/biological_association/dwc_extensions.rb on lines 98..110

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status