Sign upLogin

SpeciesFileGroup/taxonworks

View on GitHub
Star
app/models/concerns/shared/taxonomy.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method set_taxonomy has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def set_taxonomy
      c = case self.class.base_class.name
          when 'CollectionObject'
            a = current_taxon_name
Severity: Minor
Found in app/models/concerns/shared/taxonomy.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid more than 3 levels of block nesting.
Open

            if a = c.ancestor_at_rank(:kingdom)
              @taxonomy['kingdom'] = a.name
            else

              # TODO: re-add when dwc_fields merged
Severity: Minor
Found in app/models/concerns/shared/taxonomy.rb by rubocop

This cop checks for excessive nesting of conditional and looping constructs.

You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

The maximum level of nesting allowed is configurable.

TODO found
Open

            # !! Careful/TODO this is an arbitrary choice, technically can be only one primary, but not restricted in DB yet
Severity: Minor
Found in app/models/concerns/shared/taxonomy.rb by fixme

TODO found
Open

              # TODO: re-add when dwc_fields merged
Severity: Minor
Found in app/models/concerns/shared/taxonomy.rb by fixme

TODO found
Open

    # TODO: analyze and optimize for n+1
Severity: Minor
Found in app/models/concerns/shared/taxonomy.rb by fixme

There are no issues that match your filters.

Category
Status