Sign upLogin

SpeciesFileGroup/taxonworks

View on GitHub
Star
app/models/taxon_name_classification/iczn/unavailable/non_binominal.rb

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  class SubspeciesNotTrinominal < TaxonNameClassification::Iczn::Unavailable::NonBinominal

  NOMEN_URI='http://purl.obolibrary.org/obo/NOMEN_0000173'.freeze

    def applicable_ranks
Severity: Minor
Found in app/models/taxon_name_classification/iczn/unavailable/non_binominal.rb and 1 other location - About 50 mins to fix
app/models/taxon_name_classification/iczn/unavailable/non_binominal.rb on lines 42..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  class SpeciesNotBinominal < TaxonNameClassification::Iczn::Unavailable::NonBinominal

  NOMEN_URI='http://purl.obolibrary.org/obo/NOMEN_0000172'.freeze

    def applicable_ranks
Severity: Minor
Found in app/models/taxon_name_classification/iczn/unavailable/non_binominal.rb and 1 other location - About 50 mins to fix
app/models/taxon_name_classification/iczn/unavailable/non_binominal.rb on lines 82..99

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Use 2 (not 0) spaces for indentation.
Open

  NOMEN_URI='http://purl.obolibrary.org/obo/NOMEN_0000172'.freeze
Severity: Minor
Found in app/models/taxon_name_classification/iczn/unavailable/non_binominal.rb by rubocop

This cop checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Use 2 (not 0) spaces for indentation.
Open

  NOMEN_URI='http://purl.obolibrary.org/obo/NOMEN_0000171'.freeze
Severity: Minor
Found in app/models/taxon_name_classification/iczn/unavailable/non_binominal.rb by rubocop

This cop checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Use 2 (not 0) spaces for indentation.
Open

  NOMEN_URI='http://purl.obolibrary.org/obo/NOMEN_0000173'.freeze
Severity: Minor
Found in app/models/taxon_name_classification/iczn/unavailable/non_binominal.rb by rubocop

This cop checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Use 2 (not 0) spaces for indentation.
Open

  NOMEN_URI='http://purl.obolibrary.org/obo/NOMEN_0000170'.freeze
Severity: Minor
Found in app/models/taxon_name_classification/iczn/unavailable/non_binominal.rb by rubocop

This cop checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

There are no issues that match your filters.

Category
Status