Sign upLogin

SpeciesFileGroup/taxonworks

View on GitHub
Star
app/models/taxon_name_relationship/iczn/invalidating/synonym/objective.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method has too many lines. [38/25]
Open

  def sv_fix_objective_synonym_relationship
    fixed = false
    s = self.subject_taxon_name
    o = self.object_taxon_name
    if s.get_primary_type.empty?
Severity: Minor
Found in app/models/taxon_name_relationship/iczn/invalidating/synonym/objective.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method sv_fix_objective_synonym_relationship has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  def sv_fix_objective_synonym_relationship
    fixed = false
    s = self.subject_taxon_name
    o = self.object_taxon_name
    if s.get_primary_type.empty?
Severity: Minor
Found in app/models/taxon_name_relationship/iczn/invalidating/synonym/objective.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sv_fix_objective_synonym_relationship has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def sv_fix_objective_synonym_relationship
    fixed = false
    s = self.subject_taxon_name
    o = self.object_taxon_name
    if s.get_primary_type.empty?
Severity: Minor
Found in app/models/taxon_name_relationship/iczn/invalidating/synonym/objective.rb - About 1 hr to fix

    Use find_by instead of where.first.
    Open

          c2 = tnr2.citations.where(is_original: true).first
    Severity: Minor
    Found in app/models/taxon_name_relationship/iczn/invalidating/synonym/objective.rb by rubocop

    This cop is used to identify usages of where.first and change them to use find_by instead.

    Example:

    # bad
User.where(name: 'Bruce').first
User.where(name: 'Bruce').take

# good
User.find_by(name: 'Bruce')

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      def sv_objective_synonym_relationship
    s = self.subject_taxon_name
    o = self.object_taxon_name
    if (s.type_taxon_name != o.type_taxon_name ) || !s.has_same_primary_type(o)
      soft_validations.add(:type, "Objective synonyms #{s.cached_html} and #{o.cached_html} should have the same type")
    Severity: Minor
    Found in app/models/taxon_name_relationship/iczn/invalidating/synonym/objective.rb and 2 other locations - About 25 mins to fix
    app/models/taxon_name_relationship/icn/unaccepting/synonym/homotypic.rb on lines 29..34
    app/models/taxon_name_relationship/icnp/unaccepting/synonym/homotypic.rb on lines 29..34

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 31.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status