Sign upLogin

SpeciesFileGroup/taxonworks

View on GitHub
Star
app/models/taxon_name_relationship/iczn/potentially_validating/replacement_name.rb

Summary

Maintainability
A
0 mins
Test Coverage

Use find_by instead of where.first.
Open

    r2 = TaxonNameRelationship.where(type: 'TaxonNameRelationship::Iczn::Invalidating::Synonym::Objective::UnnecessaryReplacementName', subject_taxon_name_id: s.id, object_taxon_name_id: o.id).first
Severity: Minor
Found in app/models/taxon_name_relationship/iczn/potentially_validating/replacement_name.rb by rubocop

This cop is used to identify usages of where.first and change them to use find_by instead.

Example:

# bad
User.where(name: 'Bruce').first
User.where(name: 'Bruce').take

# good
User.find_by(name: 'Bruce')

Use find_by instead of where.first.
Open

    r1 = TaxonNameRelationship.where(type: 'TaxonNameRelationship::Iczn::Invalidating::Synonym::Objective::ReplacedHomonym', subject_taxon_name_id: o.id, object_taxon_name_id: s.id).first
Severity: Minor
Found in app/models/taxon_name_relationship/iczn/potentially_validating/replacement_name.rb by rubocop

This cop is used to identify usages of where.first and change them to use find_by instead.

Example:

# bad
User.where(name: 'Bruce').first
User.where(name: 'Bruce').take

# good
User.find_by(name: 'Bruce')

There are no issues that match your filters.

Category
Status