Sign upLogin

SpeciesFileGroup/taxonworks

View on GitHub
Star
lib/batch_load/import.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method create has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    def create
      @create_attempted = true


      if ready_to_create?
Severity: Minor
Found in lib/batch_load/import.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Import has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Import

    # An index of all rows for which some data was present,
    # index is line number, points to a RowParse instance
    attr_accessor :processed_rows
Severity: Minor
Found in lib/batch_load/import.rb - About 2 hrs to fix

    Consider simplifying this complex logical expression.
    Open

          return false unless @project_id && @user && @file && csv && errors.empty? && file_errors.empty?
    Severity: Major
    Found in lib/batch_load/import.rb - About 40 mins to fix

      TODO found
      Open

              # TODO: DRY
      Severity: Minor
      Found in lib/batch_load/import.rb by fixme

      There are no issues that match your filters.

      Category
      Status