lib/batch_load/import/collecting_events/castor_interpreter.rb
Method build_collecting_events has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring. Open
Open
def build_collecting_events
# DRMFieldNumbers DRMFN
namespace_drm_field_numbers = Namespace.find_by(name: 'DRMFieldNumbers')
@total_data_lines = 0- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method build_collecting_events has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def build_collecting_events
# DRMFieldNumbers DRMFN
namespace_drm_field_numbers = Namespace.find_by(name: 'DRMFieldNumbers')
@total_data_lines = 0Use find_by instead of dynamic find_by_self_and_parents. Open
Open
geographic_areas = GeographicArea.find_by_self_and_parents(geographic_area_params)- Read upRead up
- Exclude checks
This cop checks dynamic find_by_* methods.
Use find_by instead of dynamic method.
See. https://github.com/rubocop-hq/rails-style-guide#find_by
Example:
# bad
User.find_by_name(name)
# bad
User.find_by_name_and_email(name)
# bad
User.find_by_email!(name)
# good
User.find_by(name: name)
# good
User.find_by(name: name, email: email)
# good
User.find_by!(email: email)