Method to_s_verbose has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring. Open
def to_s_verbose
d = data
str = ''
d.keys.sort{|a,b| (a || 'zzz') <=> (b || 'zzz')}.each do |c|- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method has too many lines. [26/25] Open
def to_s_verbose
d = data
str = ''
d.keys.sort{|a,b| (a || 'zzz') <=> (b || 'zzz')}.each do |c|- Read upRead up
- Exclude checks
This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.
Method to_s has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def to_s
d = data
str = ''
d.keys.sort{|a,b| (a || 'zzz') <=> (b || 'zzz')}.each do |c|- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method to_s_verbose has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
def to_s_verbose
d = data
str = ''
d.keys.sort{|a,b| (a || 'zzz') <=> (b || 'zzz')}.each do |c|Method data has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def data
r = raw_data
d = {} # country => [state => [county]]
items.each do |i|- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Prefer symbols instead of strings as hash keys. Open
type_materials = TypeMaterial.joins(protonym: [:otus]).where('otus.id' => a)- Read upRead up
- Exclude checks
This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.
Example:
# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }
# good
{ one: 1, two: 2, three: 3 }