lib/catalog/distribution/entry_item.rb
Method geographic_name_classification has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
def geographic_name_classification
return @geographic_name_classification if @geographic_name_classification
case object.class.base_class.name
when 'AssertedDistribution'
@geographic_name_classification ||= object.geographic_area.geographic_name_classification- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Prefer symbols instead of strings as hash keys. Open
Open
'history-is-valid' => linked_to_valid_taxon_name?- Read upRead up
- Exclude checks
This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.
Example:
# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }
# good
{ one: 1, two: 2, three: 3 }Prefer symbols instead of strings as hash keys. Open
Open
'history-otu-taxon-name-id' => taxon_name_global_id,- Read upRead up
- Exclude checks
This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.
Example:
# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }
# good
{ one: 1, two: 2, three: 3 }