Sign upLogin

SpeciesFileGroup/taxonworks

View on GitHub
Star
lib/queries/concerns/protocols.rb

Summary

Maintainability
B
4 hrs
Test Coverage

TODO found
Open

      protocol_id: [],     # TODO: unused? or maybe in polymorphics setters!!
Severity: Minor
Found in lib/queries/concerns/protocols.rb by fixme

TODO found
Open

      :protocol_id,        # TODO: unused? or maybe in polymorphics setters!!
Severity: Minor
Found in lib/queries/concerns/protocols.rb by fixme

TODO found
Open

    # TODO: why here?
Severity: Minor
Found in lib/queries/concerns/protocols.rb by fixme

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def matching_protocol_id_and
    return nil if protocol_id_and.empty?
    l = table.name
    k = l.classify.safe_constantize
    t = ::ProtocolRelationship.arel_table
Severity: Major
Found in lib/queries/concerns/protocols.rb and 1 other location - About 3 hrs to fix
lib/queries/concerns/tags.rb on lines 113..144

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 131.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def matching_protocol_id_or
    return nil if protocol_id_or.empty?
    k = table.name.classify.safe_constantize
    t = ::ProtocolRelationship.arel_table
Severity: Major
Found in lib/queries/concerns/protocols.rb and 1 other location - About 1 hr to fix
lib/queries/concerns/tags.rb on lines 102..110

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status