SpeciesFileGroup/taxonworks

View on GitHub
lib/queries/taxon_name_classification/filter.rb

Summary

Maintainability
A
35 mins
Test Coverage

Method classification_types has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

      def classification_types
        return [] if taxon_name_classification_set.empty?
        t = []

        taxon_name_classification_set.each do |i|
Severity: Minor
Found in lib/queries/taxon_name_classification/filter.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Freeze mutable objects assigned to constants.
Open

      PARAMS = [
        :taxon_name_id,
        :taxon_name_classification_type,
        :taxon_name_classification_set,
        taxon_name_id: [],

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Strict mode can be used to freeze all constants, rather than just literals. Strict mode is considered an experimental feature. It has not been updated with an exhaustive list of all methods that will produce frozen objects so there is a decent chance of getting some false positives. Luckily, there is no harm in freezing an already frozen object.

Example: EnforcedStyle: literals (default)

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

# good
CONST = <<~TESTING.freeze
  This is a heredoc
TESTING

# good
CONST = Something.new

Example: EnforcedStyle: strict

# bad
CONST = Something.new

# bad
CONST = Struct.new do
  def foo
    puts 1
  end
end

# good
CONST = Something.new.freeze

# good
CONST = Struct.new do
  def foo
    puts 1
  end
end.freeze

There are no issues that match your filters.

Category
Status