SpontaneousCMS/spontaneous

View on GitHub
lib/spontaneous/rack/page_controller.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class PageController has 29 methods (exceeds 20 allowed). Consider refactoring.
Open

  class PageController < Sinatra::Base
    class << self
      # We wrap Sinatra's route methods in order to do two things:
      #   1. To provide a path of '*' when none is given and
      #   2. To register the presence of a handler for each method in order to
Severity: Minor
Found in lib/spontaneous/rack/page_controller.rb - About 3 hrs to fix

    Method redirect has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def redirect(location, redirect_code=:temporary)
          if String === location
            destination = @site[location]
            location = destination.path if destination and destination.respond_to?(:path)
          else
    Severity: Minor
    Found in lib/spontaneous/rack/page_controller.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status