Sign upLogin

Starbugstone/SnowTricks

View on GitHub
Star

Showing 30 of 33 total issues

Method getSubscribedEvents has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function getSubscribedEvents()
    {
        return [
            UserRegisteredEvent::NAME => [
                ['setPassword', 50],
Severity: Minor
Found in src/EventSubscriber/User/UserAccountSubscriber.php - About 1 hr to fix

    Method buildForm has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $builder
            ->add('plainPassword', RepeatedType::class, [
                'type' => PasswordType::class,
    Severity: Minor
    Found in src/Form/UserChangePasswordFormType.php - About 1 hr to fix

      Method show has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function show(Trick $trick, string $slug, Request $request)
    {
        //Checking if slug is equal to the ID. This is for SEO and external links
        if ($trick->getSlug() !== $slug) {
            return $this->correctSlug($trick);
      Severity: Minor
      Found in src/Controller/Trick/ShowTrickController.php - About 1 hr to fix

        Function searchTricks has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function searchTricks(string $query)
    {

        $query = $this->sanitizeSearchQuery($query);
        $searchTerms = $this->extractSearchTerms($query);
        Severity: Minor
        Found in src/Search/TrickSearch.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (data.isPrimary) {
                image.classList.add('primary-trick-image');
                if (data.isCarousel === "false"){
                    primaryImage.src = data.image;
                }
        Severity: Minor
        Found in assets/js/axiosCalls.js and 1 other location - About 40 mins to fix
        assets/js/axiosCalls.js on lines 44..50

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    } else {
                image.classList.remove('primary-trick-image');
                if (data.isCarousel === "false"){
                    primaryImage.src = data.defaultPrimaryImage;
                }
        Severity: Minor
        Found in assets/js/axiosCalls.js and 1 other location - About 40 mins to fix
        assets/js/axiosCalls.js on lines 38..44

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method send has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function send(string $subject, string $template, $mailData, string $to, String $from = null): bool
        Severity: Minor
        Found in src/Mail/SendMail.php - About 35 mins to fix

          Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  TrickRepository $trickRepository,
        CategoryRepository $categoryRepository,
        TagRepository $tagRepository,
        ImageRepository $imageRepository,
        VideoRepository $videoRepository
          Severity: Minor
          Found in src/Search/TrickSearch.php - About 35 mins to fix

            Function setPrimaryImageToggle has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function setPrimaryImageToggle(ImageSetPrimaryEvent $event)
    {

        $trick = $event->getTrick();
        $image = $event->getEntity();
            Severity: Minor
            Found in src/EventSubscriber/Image/ImageSetPrimarySubscriber.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function edit has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function edit(Trick $trick, Request $request)
    {
        $originalTrickImages = $trick->getImages()->count();
        /** @var Form $form */
        $form = $this->createForm(TrickFormType::class, $trick, [
            Severity: Minor
            Found in src/Controller/Trick/Admin/EditTrickController.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language