Starrier/commons

View on GitHub

Showing 59 of 59 total issues

Method isBlank has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

public static boolean isBlank(CharSequence cs) {
int strLen = length(cs);
if (strLen == 0) {
return true;
} else {
Severity: Minor
Found in src/main/java/org/starrier/common/utils/StringUtils.java - About 35 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

public static <T> Map<String, T> gsonToMaps(String gsonString) {
Map<String, T> map = null;
if (gson != null) {
map = gson.fromJson(gsonString, new TypeToken<Map<String, T>>() {
}.getType());
Severity: Minor
Found in src/main/java/org/starrier/common/utils/GsonUtil.java and 1 other location - About 30 mins to fix
src/main/java/org/starrier/common/utils/GsonUtil.java on lines 76..83

Similar blocks of code found in 2 locations. Consider refactoring.
Open

public static <T> List<Map<String, T>> gsonToListMaps(String gsonString) {
List<Map<String, T>> list = null;
if (gson != null) {
list = gson.fromJson(gsonString, new TypeToken<List<Map<String, T>>>() {
}.getType());
Severity: Minor
Found in src/main/java/org/starrier/common/utils/GsonUtil.java and 1 other location - About 30 mins to fix
src/main/java/org/starrier/common/utils/GsonUtil.java on lines 91..98

Avoid too many return statements within this method.
Open

return (cal.getTime().getTime());
Severity: Major
Found in src/main/java/org/starrier/common/utils/DateUtils.java - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

    return new Date();
    Severity: Major
    Found in src/main/java/org/starrier/common/utils/DateUtils.java - About 30 mins to fix

      Identical blocks of code found in 4 locations. Consider refactoring.
      Open

      if (ip == null || ip.length() == 0 || UNKNOWN.equalsIgnoreCase(ip)) {
      ip = request.getHeader(HTTP_X_FORWARDED_FOR);
      }
      Severity: Major
      Found in src/main/java/org/starrier/common/utils/HttpUtils.java and 3 other locations - About 30 mins to fix
      src/main/java/org/starrier/common/utils/HttpUtils.java on lines 63..65
      src/main/java/org/starrier/common/utils/HttpUtils.java on lines 66..68
      src/main/java/org/starrier/common/utils/HttpUtils.java on lines 69..71

      Avoid too many return statements within this method.
      Open

      return parseDate(source, FOR_MARTS.get(0));
      Severity: Major
      Found in src/main/java/org/starrier/common/utils/DateUtils.java - About 30 mins to fix

        Identical blocks of code found in 4 locations. Consider refactoring.
        Open

        if (ip == null || ip.length() == 0 || UNKNOWN.equalsIgnoreCase(ip)) {
        ip = request.getHeader(PROXY_CLIENT_IP);
        }
        Severity: Major
        Found in src/main/java/org/starrier/common/utils/HttpUtils.java and 3 other locations - About 30 mins to fix
        src/main/java/org/starrier/common/utils/HttpUtils.java on lines 66..68
        src/main/java/org/starrier/common/utils/HttpUtils.java on lines 69..71
        src/main/java/org/starrier/common/utils/HttpUtils.java on lines 72..74

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

        if (ip == null || ip.length() == 0 || "unknown".equalsIgnoreCase(ip)) {
        ip = request.getHeader("HTTP_CLIENT_IP");
        }
        Severity: Major
        Found in src/main/java/org/starrier/common/utils/IpUtil.java and 3 other locations - About 30 mins to fix
        src/main/java/org/starrier/common/utils/IpUtil.java on lines 20..22
        src/main/java/org/starrier/common/utils/IpUtil.java on lines 24..26
        src/main/java/org/starrier/common/utils/IpUtil.java on lines 32..34

        Avoid too many return statements within this method.
        Confirmed

        return defaultSupplier.get();
        Severity: Major
        Found in src/main/java/org/starrier/common/utils/json/JacksonUtils.java - About 30 mins to fix

          Identical blocks of code found in 4 locations. Consider refactoring.
          Open

          if (ip == null || ip.length() == 0 || UNKNOWN.equalsIgnoreCase(ip)) {
          ip = request.getHeader(HTTP_CLIENT_IP);
          }
          Severity: Major
          Found in src/main/java/org/starrier/common/utils/HttpUtils.java and 3 other locations - About 30 mins to fix
          src/main/java/org/starrier/common/utils/HttpUtils.java on lines 63..65
          src/main/java/org/starrier/common/utils/HttpUtils.java on lines 66..68
          src/main/java/org/starrier/common/utils/HttpUtils.java on lines 72..74

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          if (ip == null || ip.length() == 0 || "unknown".equalsIgnoreCase(ip)) {
          ip = request.getHeader("WL-Proxy-Client-IP");
          }
          Severity: Major
          Found in src/main/java/org/starrier/common/utils/IpUtil.java and 3 other locations - About 30 mins to fix
          src/main/java/org/starrier/common/utils/IpUtil.java on lines 20..22
          src/main/java/org/starrier/common/utils/IpUtil.java on lines 28..30
          src/main/java/org/starrier/common/utils/IpUtil.java on lines 32..34

          Avoid too many return statements within this method.
          Open

          return (cal.getTime().getTime());
          Severity: Major
          Found in src/main/java/org/starrier/common/utils/DateUtils.java - About 30 mins to fix

            Identical blocks of code found in 4 locations. Consider refactoring.
            Open

            if (ip == null || ip.length() == 0 || UNKNOWN.equalsIgnoreCase(ip)) {
            ip = request.getHeader(WL_PROXY_CLIENT_IP);
            }
            Severity: Major
            Found in src/main/java/org/starrier/common/utils/HttpUtils.java and 3 other locations - About 30 mins to fix
            src/main/java/org/starrier/common/utils/HttpUtils.java on lines 63..65
            src/main/java/org/starrier/common/utils/HttpUtils.java on lines 69..71
            src/main/java/org/starrier/common/utils/HttpUtils.java on lines 72..74

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

            if (ip == null || ip.length() == 0 || "unknown".equalsIgnoreCase(ip)) {
            ip = request.getHeader("HTTP_X_FORWARDED_FOR");
            }
            Severity: Major
            Found in src/main/java/org/starrier/common/utils/IpUtil.java and 3 other locations - About 30 mins to fix
            src/main/java/org/starrier/common/utils/IpUtil.java on lines 20..22
            src/main/java/org/starrier/common/utils/IpUtil.java on lines 24..26
            src/main/java/org/starrier/common/utils/IpUtil.java on lines 28..30

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

            if (ip == null || ip.length() == 0 || "unknown".equalsIgnoreCase(ip)) {
            ip = request.getHeader("Proxy-Client-IP");
            }
            Severity: Major
            Found in src/main/java/org/starrier/common/utils/IpUtil.java and 3 other locations - About 30 mins to fix
            src/main/java/org/starrier/common/utils/IpUtil.java on lines 24..26
            src/main/java/org/starrier/common/utils/IpUtil.java on lines 28..30
            src/main/java/org/starrier/common/utils/IpUtil.java on lines 32..34

            Avoid too many return statements within this method.
            Confirmed

            return mapper.writeValueAsString(obj);
            Severity: Major
            Found in src/main/java/org/starrier/common/utils/json/JacksonUtils.java - About 30 mins to fix

              Method stop has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              public static void stop(SRunnable sr) {
              if (sr.getName() == null) {
              throw new UnsupportedOperationException("停止线程时,线程名不能为空!");
              }
              if (pool == null || pool.isShutdown()) return;//服务未启动
              Severity: Minor
              Found in src/main/java/org/starrier/common/utils/ScheduleUtil.java - About 25 mins to fix

              Method convert has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              @Override
              public Date convert(String source) {
              String value = source.trim();
              if (StringUtils.EMPTY.equals(value)) {
              return new Date();
              Severity: Minor
              Found in src/main/java/org/starrier/common/utils/DateUtils.java - About 25 mins to fix
              Severity
              Category
              Status
              Source
              Language