Sign upLogin

Starrier/commons

View on GitHub
Star
src/main/java/org/starrier/common/utils/HttpUtils.java

Summary

Maintainability
B
6 hrs
Test Coverage

Showing 6 of 6 total issues

Method getIpAddress has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    public static String getIpAddress(HttpServletRequest request) {
        String ip = request.getHeader(X_FORWARDED_FOR);
        if (ip == null || ip.length() == 0 || UNKNOWN.equalsIgnoreCase(ip)) {
            if (ip == null || ip.length() == 0 || UNKNOWN.equalsIgnoreCase(ip)) {
                ip = request.getHeader(PROXY_CLIENT_IP);
Severity: Minor
Found in src/main/java/org/starrier/common/utils/HttpUtils.java - About 3 hrs to fix

Method getIpAddress has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static String getIpAddress(HttpServletRequest request) {
        String ip = request.getHeader(X_FORWARDED_FOR);
        if (ip == null || ip.length() == 0 || UNKNOWN.equalsIgnoreCase(ip)) {
            if (ip == null || ip.length() == 0 || UNKNOWN.equalsIgnoreCase(ip)) {
                ip = request.getHeader(PROXY_CLIENT_IP);
Severity: Minor
Found in src/main/java/org/starrier/common/utils/HttpUtils.java - About 1 hr to fix

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

                if (ip == null || ip.length() == 0 || UNKNOWN.equalsIgnoreCase(ip)) {
                    ip = request.getHeader(HTTP_CLIENT_IP);
                }
    Severity: Major
    Found in src/main/java/org/starrier/common/utils/HttpUtils.java and 3 other locations - About 30 mins to fix
    src/main/java/org/starrier/common/utils/HttpUtils.java on lines 63..65
    src/main/java/org/starrier/common/utils/HttpUtils.java on lines 66..68
    src/main/java/org/starrier/common/utils/HttpUtils.java on lines 72..74

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

                if (ip == null || ip.length() == 0 || UNKNOWN.equalsIgnoreCase(ip)) {
                    ip = request.getHeader(HTTP_X_FORWARDED_FOR);
                }
    Severity: Major
    Found in src/main/java/org/starrier/common/utils/HttpUtils.java and 3 other locations - About 30 mins to fix
    src/main/java/org/starrier/common/utils/HttpUtils.java on lines 63..65
    src/main/java/org/starrier/common/utils/HttpUtils.java on lines 66..68
    src/main/java/org/starrier/common/utils/HttpUtils.java on lines 69..71

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

                if (ip == null || ip.length() == 0 || UNKNOWN.equalsIgnoreCase(ip)) {
                    ip = request.getHeader(WL_PROXY_CLIENT_IP);
                }
    Severity: Major
    Found in src/main/java/org/starrier/common/utils/HttpUtils.java and 3 other locations - About 30 mins to fix
    src/main/java/org/starrier/common/utils/HttpUtils.java on lines 63..65
    src/main/java/org/starrier/common/utils/HttpUtils.java on lines 69..71
    src/main/java/org/starrier/common/utils/HttpUtils.java on lines 72..74

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

                if (ip == null || ip.length() == 0 || UNKNOWN.equalsIgnoreCase(ip)) {
                    ip = request.getHeader(PROXY_CLIENT_IP);
                }
    Severity: Major
    Found in src/main/java/org/starrier/common/utils/HttpUtils.java and 3 other locations - About 30 mins to fix
    src/main/java/org/starrier/common/utils/HttpUtils.java on lines 66..68
    src/main/java/org/starrier/common/utils/HttpUtils.java on lines 69..71
    src/main/java/org/starrier/common/utils/HttpUtils.java on lines 72..74

    There are no issues that match your filters.

    Category
    Status