Sign upLogin

Starrier/commons

View on GitHub
Star
src/main/java/org/starrier/common/utils/IpUtil.java

Summary

Maintainability
A
3 hrs
Test Coverage

Showing 5 of 5 total issues

Method getIpAddress has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public static String getIpAddress(HttpServletRequest request) {
        String ip = request.getHeader("x-forwarded-for");
 
        if (ip == null || ip.length() == 0 || "unknown".equalsIgnoreCase(ip)) {
            ip = request.getHeader("Proxy-Client-IP");
Severity: Minor
Found in src/main/java/org/starrier/common/utils/IpUtil.java - About 1 hr to fix

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        if (ip == null || ip.length() == 0 || "unknown".equalsIgnoreCase(ip)) {
            ip = request.getHeader("HTTP_CLIENT_IP");
        }
Severity: Major
Found in src/main/java/org/starrier/common/utils/IpUtil.java and 3 other locations - About 30 mins to fix
src/main/java/org/starrier/common/utils/IpUtil.java on lines 20..22
src/main/java/org/starrier/common/utils/IpUtil.java on lines 24..26
src/main/java/org/starrier/common/utils/IpUtil.java on lines 32..34

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        if (ip == null || ip.length() == 0 || "unknown".equalsIgnoreCase(ip)) {
            ip = request.getHeader("WL-Proxy-Client-IP");
        }
Severity: Major
Found in src/main/java/org/starrier/common/utils/IpUtil.java and 3 other locations - About 30 mins to fix
src/main/java/org/starrier/common/utils/IpUtil.java on lines 20..22
src/main/java/org/starrier/common/utils/IpUtil.java on lines 28..30
src/main/java/org/starrier/common/utils/IpUtil.java on lines 32..34

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        if (ip == null || ip.length() == 0 || "unknown".equalsIgnoreCase(ip)) {
            ip = request.getHeader("HTTP_X_FORWARDED_FOR");
        }
Severity: Major
Found in src/main/java/org/starrier/common/utils/IpUtil.java and 3 other locations - About 30 mins to fix
src/main/java/org/starrier/common/utils/IpUtil.java on lines 20..22
src/main/java/org/starrier/common/utils/IpUtil.java on lines 24..26
src/main/java/org/starrier/common/utils/IpUtil.java on lines 28..30

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        if (ip == null || ip.length() == 0 || "unknown".equalsIgnoreCase(ip)) {
            ip = request.getHeader("Proxy-Client-IP");
        }
Severity: Major
Found in src/main/java/org/starrier/common/utils/IpUtil.java and 3 other locations - About 30 mins to fix
src/main/java/org/starrier/common/utils/IpUtil.java on lines 24..26
src/main/java/org/starrier/common/utils/IpUtil.java on lines 28..30
src/main/java/org/starrier/common/utils/IpUtil.java on lines 32..34

There are no issues that match your filters.

Category
Status