Sign upLogin

Stex/ar_mailer_revised

View on GitHub
Star

Showing 3 of 3 total issues

Method process_args has 84 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def process_args(args)
        name = File.basename $0

        options             = {}
        options[:chdir]     = '.'
Severity: Major
Found in lib/ar_mailer_revised/helpers/command_line.rb - About 3 hrs to fix

    Method process_args has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

          def process_args(args)
        name = File.basename $0

        options             = {}
        options[:chdir]     = '.'
    Severity: Minor
    Found in lib/ar_mailer_revised/helpers/command_line.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method deliver_emails has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def deliver_emails
      total_mail_count = ArMailerRevised.email_class.ready_to_deliver.count
      emails           = ArMailerRevised.email_class.ready_to_deliver.with_batch_size(@options[:batch_size])

      if emails.empty?
    Severity: Minor
    Found in lib/ar_mailer_revised/mailman.rb - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language