Studiosity/grover

File middleware_spec.rb has 792 lines of code (exceeds 250 allowed). Consider refactoring.

Wontfix

require 'spec_helper'

describe Grover::Middleware do
  subject(:mock_app) do
    builder = Rack::Builder.new

Similar blocks of code found in 2 locations. Consider refactoring.

Wontfix

    describe 'png conversion' do
      let(:grover) { instance_double Grover, show_front_cover?: false, show_back_cover?: false }

      it 'doesnt call to Grover' do
        expect(Grover).not_to receive(:new)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Wontfix

    describe 'jpeg conversion' do
      let(:grover) { instance_double Grover, show_front_cover?: false, show_back_cover?: false }

      it 'doesnt call to Grover' do
        expect(Grover).not_to receive(:new)

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Wontfix

          it 'removes JPG extension from request PATH_INFO and REQUEST_URI' do
            get 'http://www.example.org/test.jpg'
            # env state sent to downstream middleware
            expect(request_env['PATH_INFO']).to eq '/test'
            expect(request_env['REQUEST_URI']).to eq 'http://www.example.org/test'

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Wontfix

          it 'includes the parameters in the request URI' do
            get 'http://www.example.org/test.pdf?def=123&abc=456'
            # env state sent to downstream middleware
            expect(request_env['PATH_INFO']).to eq '/test'
            expect(request_env['REQUEST_URI']).to eq 'http://www.example.org/test?def=123&abc=456'

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Wontfix

          it 'removes JPEG extension from request PATH_INFO and REQUEST_URI' do
            get 'http://www.example.org/test.jpeg'
            # env state sent to downstream middleware
            expect(request_env['PATH_INFO']).to eq '/test'
            expect(request_env['REQUEST_URI']).to eq 'http://www.example.org/test'

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Wontfix

          it 'removes PNG extension from request PATH_INFO and REQUEST_URI' do
            get 'http://www.example.org/test.png'
            # env state sent to downstream middleware
            expect(request_env['PATH_INFO']).to eq '/test'
            expect(request_env['REQUEST_URI']).to eq 'http://www.example.org/test'

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Wontfix

        it 'removes PDF extension from request PATH_INFO and REQUEST_URI' do
          get 'http://www.example.org/test.pdf'
          # env state sent to downstream middleware
          expect(request_env['PATH_INFO']).to eq '/test'
          expect(request_env['REQUEST_URI']).to eq 'http://www.example.org/test'

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Wontfix

        it 'doesnt assign path environment variables' do
          get 'http://www.example.org/test.png'
          # env state sent to downstream middleware
          expect(request_env['PATH_INFO']).to eq '/test.png'
          expect(request_env).not_to have_key 'REQUEST_URI'

• Read up
  Read up

Similar blocks of code found in 8 locations. Consider refactoring.

Wontfix

        it 'request is ignored when the request path matches the ignore_path' do
          response = get 'http://www.example.org/baz/foo/bar/baz'
          expect(response.content_type).to eq 'text/html'

          response = get 'http://www.example.org/baz/foo/bar/baz.pdf'

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Wontfix

        it 'keeps the original PATH_INFO and not change to REQUEST_URI' do
          get 'http://www.example.org/test.html'
          # env state sent to downstream middleware
          expect(request_env['PATH_INFO']).to eq '/test.html'
          expect(request_env).not_to have_key 'REQUEST_URI'

• Read up
  Read up

Similar blocks of code found in 8 locations. Consider refactoring.

Wontfix

        it 'request is ignored when the request path starts with the ignore_path' do
          response = get 'http://www.example.org/foo/bar/baz'
          expect(response.content_type).to eq 'text/html'

          response = get 'http://www.example.org/foo/bar/baz.pdf'

• Read up
  Read up

Similar blocks of code found in 8 locations. Consider refactoring.

Wontfix

        it 'request is ignored when the request path passed to the proc defined in ignore_path returns true' do
          response = get 'http://www.example.org/foobazbar'
          expect(response.content_type).to eq 'text/html'

          response = get 'http://www.example.org/foobazbar.pdf'

• Read up
  Read up

Similar blocks of code found in 8 locations. Consider refactoring.

Wontfix

        it 'does not get stuck rendering each request as jpeg' do
          # renders html by default
          response = get 'http://www.example.org/test'
          expect(response.content_type).to eq 'text/html'

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Wontfix

        it 'doesnt assign path environment variables for JPEG' do
          get 'http://www.example.org/test.jpeg'
          # env state sent to downstream middleware
          expect(request_env['PATH_INFO']).to eq '/test.jpeg'
          expect(request_env).not_to have_key 'REQUEST_URI'

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Wontfix

        it 'doesnt assign path environment variables for JPG' do
          get 'http://www.example.org/test.jpg'
          # env state sent to downstream middleware
          expect(request_env['PATH_INFO']).to eq '/test.jpg'
          expect(request_env).not_to have_key 'REQUEST_URI'

• Read up
  Read up

Similar blocks of code found in 8 locations. Consider refactoring.

Wontfix

        it 'does not get stuck rendering each request as jpg' do
          # renders html by default
          response = get 'http://www.example.org/test'
          expect(response.content_type).to eq 'text/html'

• Read up
  Read up

Similar blocks of code found in 8 locations. Consider refactoring.

Wontfix

      it 'does not get stuck rendering each request as pdf' do
        # renders html by default
        response = get 'http://www.example.org/test'
        expect(response.content_type).to eq 'text/html'

• Read up
  Read up

Similar blocks of code found in 8 locations. Consider refactoring.

Wontfix

        it 'does not get stuck rendering each request as png' do
          # renders html by default
          response = get 'http://www.example.org/test'
          expect(response.content_type).to eq 'text/html'

• Read up
  Read up

Similar blocks of code found in 8 locations. Consider refactoring.

Wontfix

          it 'request is ignored when the request passed to the proc defined in ignore_request returns true' do
            response = get 'http://www.example.org/foobazbar'
            expect(response.content_type).to eq 'text/html'

            response = get 'http://www.example.org/foobazbar.pdf'

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Wontfix

          it 'doesnt assign path environment variables' do
            get 'http://www.example.org/test.pdf'
            # env state sent to downstream middleware
            expect(request_env['PATH_INFO']).to eq '/test.pdf'
            expect(request_env).not_to have_key 'REQUEST_URI'

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Wontfix

      it 'calls to the HTML preprocessor with the original HTML' do
        allow(Grover::HTMLPreprocessor).to(
          receive(:process).
            with('Grover McGroveryface', 'http://www.example.org/', 'http').
            and_return('Processed McProcessyface')

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Wontfix

        it 'calls to the HTML preprocessor with the original HTML and the specified root_url' do
          allow(Grover::HTMLPreprocessor).to(
            receive(:process).
              with('Grover McGroveryface', 'http://example.com/', 'http').
              and_return('Processed McProcessyface')

• Read up
  Read up

Similar blocks of code found in 7 locations. Consider refactoring.

Wontfix

        it 'matches PDF case insensitive' do
          get 'http://www.example.org/test.PDF'
          expect(last_response.headers['Content-Type']).to eq 'application/pdf'
          response_size = Grover.new('Grover McGroveryface').to_pdf.bytesize
          expect(last_response.body.bytesize).to eq response_size

• Read up
  Read up

Similar blocks of code found in 7 locations. Consider refactoring.

Wontfix

        it 'returns PNG content type' do
          get 'http://www.example.org/test.png'
          expect(last_response.headers['Content-Type']).to eq 'image/png'
          response_size = Grover.new('Grover McGroveryface').to_png.bytesize
          expect(last_response.body.bytesize).to eq response_size

• Read up
  Read up

Similar blocks of code found in 7 locations. Consider refactoring.

Wontfix

        it 'returns PDF content type' do
          get 'http://www.example.org/test.pdf'
          expect(last_response.headers['Content-Type']).to eq 'application/pdf'
          response_size = Grover.new('Grover McGroveryface').to_pdf.bytesize
          expect(last_response.body.bytesize).to eq response_size

• Read up
  Read up

Similar blocks of code found in 7 locations. Consider refactoring.

Wontfix

        it 'matches PNG case insensitive' do
          get 'http://www.example.org/test.PNG'
          expect(last_response.headers['Content-Type']).to eq 'image/png'
          response_size = Grover.new('Grover McGroveryface').to_png.bytesize
          expect(last_response.body.bytesize).to eq response_size

• Read up
  Read up

Similar blocks of code found in 7 locations. Consider refactoring.

Wontfix

        it 'matches JPEG case insensitive' do
          get 'http://www.example.org/test.JPEG'
          expect(last_response.headers['Content-Type']).to eq 'image/jpeg'
          response_size = Grover.new('Grover McGroveryface').to_jpeg.bytesize
          expect(last_response.body.bytesize).to eq response_size

• Read up
  Read up

Similar blocks of code found in 7 locations. Consider refactoring.

Wontfix

        it 'matches JPG case insensitive' do
          get 'http://www.example.org/test.JPG'
          expect(last_response.headers['Content-Type']).to eq 'image/jpeg'
          response_size = Grover.new('Grover McGroveryface').to_jpeg.bytesize
          expect(last_response.body.bytesize).to eq response_size

• Read up
  Read up

Similar blocks of code found in 7 locations. Consider refactoring.

Wontfix

        it 'returns JPEG content type' do
          get 'http://www.example.org/test.jpeg'
          expect(last_response.headers['Content-Type']).to eq 'image/jpeg'
          response_size = Grover.new('Grover McGroveryface').to_jpeg.bytesize
          expect(last_response.body.bytesize).to eq response_size

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Wontfix

          context 'when the root_url is also set in configuration' do
            before { allow(Grover.configuration).to receive(:root_url).and_return 'http://other.domain/' }

            it 'uses the specified root_url in the middleware initializer' do
              get 'http://www.example.org/test.pdf'

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Wontfix

      context 'when request doesnt have an extension' do
        it 'returns the downstream content type' do
          get 'http://www.example.org/test'
          expect(last_response.headers['Content-Type']).to eq 'text/html'
          expect(last_response.body).to eq 'Grover McGroveryface'

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Wontfix

        context 'with root_url set in configuration' do
          before { allow(Grover.configuration).to receive(:root_url).and_return 'http://example.com/' }

          it 'uses the specified root_url' do
            get 'http://www.example.org/test.pdf'

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Wontfix

      context 'when request has a non-PDF/PNG/JPEG extension' do
        it 'returns the downstream content type' do
          get 'http://www.example.org/test.html'
          expect(last_response.headers['Content-Type']).to eq 'text/html'
          expect(last_response.body).to eq 'Grover McGroveryface'

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Wontfix

          it 'returns response as JPEG' do
            get 'http://www.example.org/test.jpeg'
            expect(last_response.headers['Content-Type']).to eq 'image/jpeg'
            expect(last_response.body.bytesize).to eq Grover.new('Rackalicious').to_jpeg.bytesize

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Wontfix

        it 'returns response as PDF' do
          get 'http://www.example.org/test.pdf'
          expect(last_response.headers['Content-Type']).to eq 'application/pdf'
          expect(last_response.body.bytesize).to eq Grover.new('Rackalicious').to_pdf.bytesize

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Wontfix

          it 'returns response as PNG' do
            get 'http://www.example.org/test.png'
            expect(last_response.headers['Content-Type']).to eq 'image/png'
            expect(last_response.body.bytesize).to eq Grover.new('Rackalicious').to_png.bytesize

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Wontfix

        it 'returns response as PDF' do
          get 'http://www.example.org/test.pdf'
          expect(last_response.headers['Content-Type']).to eq 'application/pdf'
          expect(last_response.body.bytesize).to eq Grover.new('Part 1Part 2').to_pdf.bytesize

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Wontfix

          it 'returns response as JPG' do
            get 'http://www.example.org/test.jpg'
            expect(last_response.headers['Content-Type']).to eq 'image/jpeg'
            expect(last_response.body.bytesize).to eq Grover.new('Rackalicious').to_jpeg.bytesize

• Read up
  Read up